On Thu, Sep 05, 2013 at 04:41:31PM -0700, Sudeep Dutt wrote:
> drivers/misc/mic/common/mic_device.h | 37 +++
> drivers/misc/mic/host/mic_device.h| 109 +
Two different files, with the same name? You are asking for trouble in
the future, getting them confused :)
Ple
Very minor nits, you can change this in a future add-on patch:
> +static DEVICE_ATTR(family, S_IRUGO, mic_show_family, NULL);
This should use DEVICE_ATTR_RO(), so that we don't have to audit the
permissions of your DEVICE_ATTR() files.
> +static DEVICE_ATTR(stepping, S_IRUGO, mic_show_stepping,
This patch enables the following:
a) Initializes the Intel MIC X100 PCIe devices.
b) Provides sysfs entries for family and stepping information.
Co-author: Dasaratharaman Chandramouli
Signed-off-by: Ashutosh Dixit
Signed-off-by: Caz Yokoyama
Signed-off-by: Dasaratharaman Chandramouli
Signed-o
3 matches
Mail list logo
