Re: [PATCH RESEND v2 2/7] mfd: cros_ec: Add char dev and virtual dev pointers

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Javier Martinez Canillas wrote: > Hello Lee, > > On 01/20/2015 05:36 PM, Lee Jones wrote: > >> > > >> > Is this safe? Are you sure it's okay to provide an interface from > >> > userspace to read (kernel?) memory? > >> > > >> > >> This interface is not to read any kernel me

Re: [PATCH RESEND v2 2/7] mfd: cros_ec: Add char dev and virtual dev pointers

2015-01-20 Thread Javier Martinez Canillas
Hello Lee, On 01/20/2015 05:36 PM, Lee Jones wrote: >> > >> > Is this safe? Are you sure it's okay to provide an interface from >> > userspace to read (kernel?) memory? >> > >> >> This interface is not to read any kernel memory but only the memory mapped >> I/O region for the Low Pin Count (LPC

Re: [PATCH RESEND v2 2/7] mfd: cros_ec: Add char dev and virtual dev pointers

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Javier Martinez Canillas wrote: > Hello Lee, > > Thanks a lot for your feedback. > > On 01/20/2015 08:50 AM, Lee Jones wrote: > >> @@ -59,9 +60,17 @@ struct cros_ec_command { > >> * > >> * @ec_name: name of EC device (e.g. 'chromeos-ec') > >> * @phys_name: name of phys

Re: [PATCH RESEND v2 2/7] mfd: cros_ec: Add char dev and virtual dev pointers

2015-01-20 Thread Javier Martinez Canillas
Hello Lee, Thanks a lot for your feedback. On 01/20/2015 08:50 AM, Lee Jones wrote: >> @@ -59,9 +60,17 @@ struct cros_ec_command { >> * >> * @ec_name: name of EC device (e.g. 'chromeos-ec') >> * @phys_name: name of physical comms layer (e.g. 'i2c-4') >> - * @dev: Device pointer >> + * @dev:

Re: [PATCH RESEND v2 2/7] mfd: cros_ec: Add char dev and virtual dev pointers

2015-01-19 Thread Lee Jones
On Fri, 02 Jan 2015, Javier Martinez Canillas wrote: > The ChromeOS Embedded Controller has to be accessed by applications. > A virtual character device is used as an interface with user-space. > > Extend the struct cros_ec_device with the fields needed by the driver > of this virtual character d

[PATCH RESEND v2 2/7] mfd: cros_ec: Add char dev and virtual dev pointers

2015-01-02 Thread Javier Martinez Canillas
The ChromeOS Embedded Controller has to be accessed by applications. A virtual character device is used as an interface with user-space. Extend the struct cros_ec_device with the fields needed by the driver of this virtual character device. Signed-off-by: Javier Martinez Canillas --- Changes si