Re: [PATCH RESEND v10 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-26 Thread Kishon Vijay Abraham I
On Thursday 27 February 2014 12:11 PM, Loc Ho wrote: Hi, + +static void sds_wr(void __iomem *csr_base, u32 indirect_cmd_reg, + u32 indirect_data_reg, u32 addr, u32 data) +{ + u32 val; + u32 cmd; + + cmd = CFG_IND_WR_CMD_MASK | CFG_IND_CMD_DONE_MASK; + cm

Re: [PATCH RESEND v10 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-26 Thread Kishon Vijay Abraham I
On Thursday 27 February 2014 12:04 PM, Kishon Vijay Abraham I wrote: On Thursday 27 February 2014 11:55 AM, Loc Ho wrote: Hi, + +static void sds_wr(void __iomem *csr_base, u32 indirect_cmd_reg, + u32 indirect_data_reg, u32 addr, u32 data) +{ + u32 val; + u32 cmd; +

Re: [PATCH RESEND v10 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-26 Thread Loc Ho
Hi, >> + >> +static void sds_wr(void __iomem *csr_base, u32 indirect_cmd_reg, >> + u32 indirect_data_reg, u32 addr, u32 data) >> +{ >> + u32 val; >> + u32 cmd; >> + >> + cmd = CFG_IND_WR_CMD_MASK | CFG_IND_CMD_DONE_MASK; >> +

Re: [PATCH RESEND v10 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-26 Thread Kishon Vijay Abraham I
On Thursday 27 February 2014 11:55 AM, Loc Ho wrote: Hi, + +static void sds_wr(void __iomem *csr_base, u32 indirect_cmd_reg, + u32 indirect_data_reg, u32 addr, u32 data) +{ + u32 val; + u32 cmd; + + cmd = CFG_IND_WR_CMD_MASK | CFG_IND_CMD_DONE_MASK; + cm

Re: [PATCH RESEND v10 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-26 Thread Loc Ho
Hi, + +static void sds_wr(void __iomem *csr_base, u32 indirect_cmd_reg, + u32 indirect_data_reg, u32 addr, u32 data) +{ + u32 val; + u32 cmd; + + cmd = CFG_IND_WR_CMD_MASK | CFG_IND_CMD_DONE_MASK; + cmd = CFG_IND

Re: [PATCH RESEND v10 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-26 Thread Kishon Vijay Abraham I
On Thursday 27 February 2014 02:15 AM, Loc Ho wrote: Hi, +config PHY_XGENE + tristate "APM X-Gene 15Gbps PHY support" + depends on ARM64 || COMPILE_TEST + select GENERIC_PHY depends on HAS_IOMEM and CONFIG_OF.. I will make it depends as "HAS_IOMEM && OF && (ARM64 || COMP

Re: [PATCH RESEND v10 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-26 Thread Loc Ho
Hi, >> >> +config PHY_XGENE >> + tristate "APM X-Gene 15Gbps PHY support" >> + depends on ARM64 || COMPILE_TEST >> + select GENERIC_PHY > > > depends on HAS_IOMEM and CONFIG_OF.. I will make it depends as "HAS_IOMEM && OF && (ARM64 || COMPILE_TEST) >> >> +/* PLL Clock Macro Uni

Re: [PATCH RESEND v10 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-26 Thread Kishon Vijay Abraham I
On Tuesday 25 February 2014 11:44 AM, Loc Ho wrote: This patch adds support for APM X-Gene SoC 15Gbps Multi-purpose PHY. This is the physical layer interface for the corresponding host controller. Currently, only external clock and SATA mode are supported. Signed-off-by: Loc Ho Signed-off-by: T