Re: [alsa-devel] [PATCH RESEND V3] ASoC: cs42xx8: add reset-gpio in binding document

2019-05-16 Thread Fabio Estevam
On Thu, May 16, 2019 at 8:25 AM S.j. Wang wrote: > cs42888: codec@48 { > @@ -25,4 +30,5 @@ cs42888: codec@48 { > VD-supply = <®_audio>; > VLS-supply = <®_audio>; > VLC-supply = <®_audio>; > + reset-gpio = <&pca9557_b 1 1>; Please use GPIO_ACTIVE_LOW instead as it m

RE: [EXT] Re: [PATCH RESEND V3] ASoC: cs42xx8: add reset-gpio in binding document

2019-05-16 Thread S.j. Wang
Hi > > > +Optional properties: > > + > > + - reset-gpio : a GPIO spec to define which pin is connected to the chip's > > +!RESET pin > > gpio properties are supposed to be called -gpios even if there's a single > GPIO possible due to DT rules. The code will accept plain -gpio but the > do

Re: [PATCH RESEND V3] ASoC: cs42xx8: add reset-gpio in binding document

2019-05-16 Thread Mark Brown
On Thu, May 16, 2019 at 11:24:12AM +, S.j. Wang wrote: > +Optional properties: > + > + - reset-gpio : a GPIO spec to define which pin is connected to the chip's > +!RESET pin gpio properties are supposed to be called -gpios even if there's a single GPIO possible due to DT rules. The cod

[PATCH RESEND V3] ASoC: cs42xx8: add reset-gpio in binding document

2019-05-16 Thread S.j. Wang
Add reset-gpio property, which is an optional option Signed-off-by: Shengjiu Wang --- Changes in RESEND v3 - send updated binding document only Changes in v3 - update binding document. Changes in v2 - use devm_gpiod_get_optional instead of of_get_named_gpio Documentation/devicetree/bindings/s