On Mon, Apr 08, 2019 at 10:48:34PM +, Ghannam, Yazen wrote:
> Okay, so drop the export and leave the injector code as-is (it's
> already doing a rdmsrl_on_cpu()).
Yes of course. The number of MCA banks is none of modules' business and
should not be exported at all.
Thx.
--
Regards/Gruss,
: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu
>
> On Mon, Apr 08, 2019 at 10:48:34PM +, Ghannam, Yazen wrote:
> > Okay, so drop the export and leave the injector code as-is (it's
> > already doing a rdmsrl_on_cpu()).
>
> It's still a globally vi
On Mon, Apr 08, 2019 at 10:48:34PM +, Ghannam, Yazen wrote:
> Okay, so drop the export and leave the injector code as-is (it's
> already doing a rdmsrl_on_cpu()).
It's still a globally visible symbol (shared by core.c and amd.c).
So I think it needs a "mce_" prefix.
While it doesn't collide n
: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu
>
> On Mon, Apr 08, 2019 at 08:42:36PM +, Luck, Tony wrote:
> > > Actually, it should not be exported at all. A function returning the num
> > > banks is better instead.
> >
> > Are all the pla
On Mon, Apr 08, 2019 at 08:42:36PM +, Luck, Tony wrote:
> > Actually, it should not be exported at all. A function returning the num
> > banks is better instead.
>
> Are all the places it is used in non-pre-emptible sections of code? Looping
> in the CMCI and #MC handlers should be fine. But d
> Actually, it should not be exported at all. A function returning the num
> banks is better instead.
Are all the places it is used in non-pre-emptible sections of code? Looping
in the CMCI and #MC handlers should be fine. But do we need get_cpu()/put_cpu()
in any places?
-Tony
On Mon, Apr 08, 2019 at 01:26:59PM -0700, Luck, Tony wrote:
> On Mon, Apr 08, 2019 at 02:12:17PM +, Ghannam, Yazen wrote:
> > +DEFINE_PER_CPU_READ_MOSTLY(u8, num_banks);
> > +EXPORT_PER_CPU_SYMBOL_GPL(num_banks);
>
> The name "num_banks" is a bit generic for an exported symbol.
> I think it sh
On Mon, Apr 08, 2019 at 02:12:17PM +, Ghannam, Yazen wrote:
> +DEFINE_PER_CPU_READ_MOSTLY(u8, num_banks);
> +EXPORT_PER_CPU_SYMBOL_GPL(num_banks);
The name "num_banks" is a bit generic for an exported symbol.
I think it should have a "mce_" prefix.
-Tony
From: Yazen Ghannam
The number of MCA banks is provided per logical CPU. Historically, this
number has been the same across all CPUs, but this is not an
architectural guarantee. Future AMD systems may have MCA bank counts
that vary between logical CPUs in a system.
This issue was partially addre
9 matches
Mail list logo
