Re: [PATCH RESEND] pwm: berlin: Don't use broken prescaler values

2018-06-06 Thread Thierry Reding
On Tue, Jun 05, 2018 at 12:48:51PM -0400, Tom Hebb wrote: > On 06/05/2018 05:10 AM, Thierry Reding wrote: > > On Mon, Jun 04, 2018 at 02:32:41PM -0400, Thomas Hebb wrote: > >> Six of the eight prescaler values available for Berlin PWM are not true > >> prescalers but rather internal shifts that thr

Re: [PATCH RESEND] pwm: berlin: Don't use broken prescaler values

2018-06-05 Thread Tom Hebb
On 06/05/2018 05:10 AM, Thierry Reding wrote: > On Mon, Jun 04, 2018 at 02:32:41PM -0400, Thomas Hebb wrote: >> Six of the eight prescaler values available for Berlin PWM are not true >> prescalers but rather internal shifts that throw away the high bits of >> TCNT. Currently, we attempt to use tho

Re: [PATCH RESEND] pwm: berlin: Don't use broken prescaler values

2018-06-05 Thread Thierry Reding
On Mon, Jun 04, 2018 at 02:32:41PM -0400, Thomas Hebb wrote: > Six of the eight prescaler values available for Berlin PWM are not true > prescalers but rather internal shifts that throw away the high bits of > TCNT. Currently, we attempt to use those high bits, leading to erratic > behavior. Restri

[PATCH RESEND] pwm: berlin: Don't use broken prescaler values

2018-06-04 Thread Thomas Hebb
Six of the eight prescaler values available for Berlin PWM are not true prescalers but rather internal shifts that throw away the high bits of TCNT. Currently, we attempt to use those high bits, leading to erratic behavior. Restrict the prescaler configurations we select to only the two that respec