Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-12 Thread Jason Baron
On 9/11/19 4:19 AM, Heiher wrote: > Hi, > > On Fri, Sep 6, 2019 at 1:48 AM Jason Baron wrote: >> >> >> >> On 9/5/19 1:27 PM, Roman Penyaev wrote: >>> On 2019-09-05 11:56, Heiher wrote: Hi, On Thu, Sep 5, 2019 at 10:53 AM Heiher wrote: > > Hi, > > I created an ep

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-11 Thread Heiher
Hi, On Fri, Sep 6, 2019 at 1:48 AM Jason Baron wrote: > > > > On 9/5/19 1:27 PM, Roman Penyaev wrote: > > On 2019-09-05 11:56, Heiher wrote: > >> Hi, > >> > >> On Thu, Sep 5, 2019 at 10:53 AM Heiher wrote: > >>> > >>> Hi, > >>> > >>> I created an epoll wakeup test project, listed some possible c

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-05 Thread Jason Baron
On 9/5/19 1:27 PM, Roman Penyaev wrote: > On 2019-09-05 11:56, Heiher wrote: >> Hi, >> >> On Thu, Sep 5, 2019 at 10:53 AM Heiher wrote: >>> >>> Hi, >>> >>> I created an epoll wakeup test project, listed some possible cases, >>> and any other corner cases needs to be added? >>> >>> https://githu

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-05 Thread Roman Penyaev
On 2019-09-05 11:56, Heiher wrote: Hi, On Thu, Sep 5, 2019 at 10:53 AM Heiher wrote: Hi, I created an epoll wakeup test project, listed some possible cases, and any other corner cases needs to be added? https://github.com/heiher/epoll-wakeup/blob/master/README.md On Wed, Sep 4, 2019 at 10:

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-05 Thread Heiher
Hi, On Thu, Sep 5, 2019 at 10:53 AM Heiher wrote: > > Hi, > > I created an epoll wakeup test project, listed some possible cases, > and any other corner cases needs to be added? > > https://github.com/heiher/epoll-wakeup/blob/master/README.md > > On Wed, Sep 4, 2019 at 10:02 PM Heiher wrote: > >

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-04 Thread Heiher
Hi, I created an epoll wakeup test project, listed some possible cases, and any other corner cases needs to be added? https://github.com/heiher/epoll-wakeup/blob/master/README.md On Wed, Sep 4, 2019 at 10:02 PM Heiher wrote: > > Hi, > > On Wed, Sep 4, 2019 at 8:02 PM Jason Baron wrote: > > > >

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-04 Thread Heiher
Hi, On Wed, Sep 4, 2019 at 8:02 PM Jason Baron wrote: > > > > On 9/4/19 5:57 AM, Roman Penyaev wrote: > > On 2019-09-03 23:08, Jason Baron wrote: > >> On 9/2/19 11:36 AM, Roman Penyaev wrote: > >>> Hi, > >>> > >>> This is indeed a bug. (quick side note: could you please remove efd[1] > >>> from y

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-04 Thread Jason Baron
On 9/4/19 5:57 AM, Roman Penyaev wrote: > On 2019-09-03 23:08, Jason Baron wrote: >> On 9/2/19 11:36 AM, Roman Penyaev wrote: >>> Hi, >>> >>> This is indeed a bug. (quick side note: could you please remove efd[1] >>> from your test, because it is not related to the reproduction of a >>> current

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-04 Thread Roman Penyaev
On 2019-09-03 23:08, Jason Baron wrote: On 9/2/19 11:36 AM, Roman Penyaev wrote: Hi, This is indeed a bug. (quick side note: could you please remove efd[1] from your test, because it is not related to the reproduction of a current bug). Your patch lacks a good description, what exactly you've

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-03 Thread Jason Baron
On 9/2/19 11:36 AM, Roman Penyaev wrote: > Hi, > > This is indeed a bug. (quick side note: could you please remove efd[1] > from your test, because it is not related to the reproduction of a > current bug). > > Your patch lacks a good description, what exactly you've fixed.  Let > me speak out

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-02 Thread Roman Penyaev
Hi, This is indeed a bug. (quick side note: could you please remove efd[1] from your test, because it is not related to the reproduction of a current bug). Your patch lacks a good description, what exactly you've fixed. Let me speak out loud and please correct me if I'm wrong, my understanding

[PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-01 Thread hev
From: Heiher The structure of event pools: efd[1]: { efd[2] (EPOLLIN) }efd[0]: { efd[2] (EPOLLIN | EPOLLET) } | | +-+-+ | v