Re: [PATCH RESEND] cifs: use memzero_explicit to clear stack buffer

2015-01-12 Thread Steve French
merged into cifs-2.6.git for-next On Tue, Jan 6, 2015 at 4:59 PM, Herbert Xu wrote: > On Tue, Jan 06, 2015 at 10:37:00PM +0100, Giel van Schijndel wrote: >> When leaving a function use memzero_explicit instead of memset(0) to >> clear stack allocated buffers. memset(0) may be optimized away. >> >

Re: [PATCH RESEND] cifs: use memzero_explicit to clear stack buffer

2015-01-09 Thread Steve French
Looks fine to me - will merge into cifs-2.6.git On Tue, Jan 6, 2015 at 3:37 PM, Giel van Schijndel wrote: > When leaving a function use memzero_explicit instead of memset(0) to > clear stack allocated buffers. memset(0) may be optimized away. > > This particular buffer is highly likely to contain

Re: [PATCH RESEND] cifs: use memzero_explicit to clear stack buffer

2015-01-06 Thread Herbert Xu
On Tue, Jan 06, 2015 at 10:37:00PM +0100, Giel van Schijndel wrote: > When leaving a function use memzero_explicit instead of memset(0) to > clear stack allocated buffers. memset(0) may be optimized away. > > This particular buffer is highly likely to contain sensitive data which > we shouldn't le

[PATCH RESEND] cifs: use memzero_explicit to clear stack buffer

2015-01-06 Thread Giel van Schijndel
When leaving a function use memzero_explicit instead of memset(0) to clear stack allocated buffers. memset(0) may be optimized away. This particular buffer is highly likely to contain sensitive data which we shouldn't leak (it's named 'passwd' after all). Signed-off-by: Giel van Schijndel Report