Re: [PATCH RESEND] SCSI not showing tray status correctly

2007-10-30 Thread James Bottomley
On Sat, 2007-10-27 at 22:58 +, Maarten Bressers wrote: > > This patch is too simplistic. ide-cd.c:ide_cdrom_drive_status() looks > > to be a reasonable implementation. However, the worry is that > > GET_EVENT_NOTIFICATION is a MMC command; devices not conforming to MMC > > won't support it.

Re: [PATCH RESEND] SCSI not showing tray status correctly

2007-10-27 Thread Maarten Bressers
> This patch is too simplistic. ide-cd.c:ide_cdrom_drive_status() looks > to be a reasonable implementation. However, the worry is that > GET_EVENT_NOTIFICATION is a MMC command; devices not conforming to MMC > won't support it. In theory, they should just return ILLEGAL_REQUEST, > but USB devic

Re: [PATCH RESEND] SCSI not showing tray status correctly

2007-10-25 Thread James Bottomley
On Thu, 2007-10-25 at 22:30 +, Maarten Bressers wrote: > From: David Martin <[EMAIL PROTECTED]> > > Greetings, > > The following patch was submitted to the lkml in 2004 by David Martin > (http://lkml.org/lkml/2004/12/27/1). It wasn't accepted, but I was > unable to find a reason why, so I'm r

[PATCH RESEND] SCSI not showing tray status correctly

2007-10-25 Thread Maarten Bressers
From: David Martin <[EMAIL PROTECTED]> Greetings, The following patch was submitted to the lkml in 2004 by David Martin (http://lkml.org/lkml/2004/12/27/1). It wasn't accepted, but I was unable to find a reason why, so I'm resending it now. Without this patch the SCSI ioctl CDROM_DRIVE_STATUS al