Re: [PATCH REBASE v4 11/14] mips: Adjust brk randomization offset to fit generic version

2019-07-25 Thread Andrew Morton
On Thu, 25 Jul 2019 13:00:33 -0700 Kees Cook wrote: > > I have just noticed that this patch is wrong, do you want me to send > > another version of the entire series or is the following diff enough ? > > This mistake gets fixed anyway in patch 13/14 when it gets merged with the > > generic versio

Re: [PATCH REBASE v4 11/14] mips: Adjust brk randomization offset to fit generic version

2019-07-25 Thread Kees Cook
On Thu, Jul 25, 2019 at 08:22:06AM +0200, Alexandre Ghiti wrote: > On 7/24/19 7:58 AM, Alexandre Ghiti wrote: > > This commit simply bumps up to 32MB and 1GB the random offset > > of brk, compared to 8MB and 256MB, for 32bit and 64bit respectively. > > > > Suggested-by: Kees Cook > > Signed-off-b

Re: [PATCH REBASE v4 11/14] mips: Adjust brk randomization offset to fit generic version

2019-07-24 Thread Alexandre Ghiti
On 7/24/19 7:58 AM, Alexandre Ghiti wrote: This commit simply bumps up to 32MB and 1GB the random offset of brk, compared to 8MB and 256MB, for 32bit and 64bit respectively. Suggested-by: Kees Cook Signed-off-by: Alexandre Ghiti Reviewed-by: Kees Cook --- arch/mips/mm/mmap.c | 7 --- 1

[PATCH REBASE v4 11/14] mips: Adjust brk randomization offset to fit generic version

2019-07-23 Thread Alexandre Ghiti
This commit simply bumps up to 32MB and 1GB the random offset of brk, compared to 8MB and 256MB, for 32bit and 64bit respectively. Suggested-by: Kees Cook Signed-off-by: Alexandre Ghiti Reviewed-by: Kees Cook --- arch/mips/mm/mmap.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)