Re: [PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-06-20 Thread Christian Ruppert
Hello Wolfram, On Wed, Jun 19, 2013 at 05:20:59PM +0200, Wolfram Sang wrote: > [...] > > > > > - It should not be encoded in the devicetree, since the flaw is implicit > > > to the device, so only the driver needs to know about it. I wonder > > > about something like this in the i2c slave dri

Re: [PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-06-19 Thread Wolfram Sang
Hi Christian, > > So, I looked around and found: > > http://www.maximintegrated.com/app-notes/index.mvp/id/3268 > > > > which after thinking further about it gives me the following > > conclusions: > > > > - sda-hold-time is a property/requirement of a device not following > > the I2C spec. It

Re: [PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-06-19 Thread Christian Ruppert
On Wed, Jun 19, 2013 at 11:45:40AM +0200, Wolfram Sang wrote: > Hi, > > On Wed, Jun 12, 2013 at 04:47:45PM +0200, Christian Ruppert wrote: > > On Mon, Jun 10, 2013 at 05:29:55PM +0200, Wolfram Sang wrote: > > > On Tue, May 14, 2013 at 03:04:02PM +0200, Christian Ruppert wrote: > > > > This patch m

Re: [PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-06-19 Thread Wolfram Sang
Hi, On Wed, Jun 12, 2013 at 04:47:45PM +0200, Christian Ruppert wrote: > On Mon, Jun 10, 2013 at 05:29:55PM +0200, Wolfram Sang wrote: > > On Tue, May 14, 2013 at 03:04:02PM +0200, Christian Ruppert wrote: > > > This patch makes the SDA hold time configurable through device tree. > > > > > > [reb

Re: [PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-06-18 Thread Andy Shevchenko
On Mon, Jun 17, 2013 at 11:55 PM, Rob Herring wrote: >> +Optional properties : >> + - sda-hold-time : should contain the SDA hold time in nanoseconds. > > Please specify time units in the property name. Perhaps > i2c-sda-hold-time-ns. > > Based on reading the discussion, there is one similar prop

Re: [PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-06-17 Thread Rob Herring
On 05/14/2013 08:04 AM, Christian Ruppert wrote: > This patch makes the SDA hold time configurable through device tree. > > [rebased to i2c-current/i2c-next/mainline-3.10-rc1] > > Signed-off-by: Christian Ruppert > Signed-off-by: Pierrick Hascoet > --- > .../devicetree/bindings/i2c/i2c-designw

Re: [PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-06-17 Thread Mika Westerberg
On Wed, Jun 12, 2013 at 04:47:45PM +0200, Christian Ruppert wrote: > On Mon, Jun 10, 2013 at 05:29:55PM +0200, Wolfram Sang wrote: > > On Tue, May 14, 2013 at 03:04:02PM +0200, Christian Ruppert wrote: > > > This patch makes the SDA hold time configurable through device tree. > > > > > > [rebased

Re: [PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-06-12 Thread Christian Ruppert
On Mon, Jun 10, 2013 at 05:29:55PM +0200, Wolfram Sang wrote: > On Tue, May 14, 2013 at 03:04:02PM +0200, Christian Ruppert wrote: > > This patch makes the SDA hold time configurable through device tree. > > > > [rebased to i2c-current/i2c-next/mainline-3.10-rc1] > > > > Signed-off-by: Christian

Re: [PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-06-10 Thread Wolfram Sang
On Tue, May 14, 2013 at 03:04:02PM +0200, Christian Ruppert wrote: > This patch makes the SDA hold time configurable through device tree. > > [rebased to i2c-current/i2c-next/mainline-3.10-rc1] > > Signed-off-by: Christian Ruppert > Signed-off-by: Pierrick Hascoet Hmm, I really have problems a

[PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-05-14 Thread Christian Ruppert
This patch makes the SDA hold time configurable through device tree. [rebased to i2c-current/i2c-next/mainline-3.10-rc1] Signed-off-by: Christian Ruppert Signed-off-by: Pierrick Hascoet --- .../devicetree/bindings/i2c/i2c-designware.txt | 14 ++ drivers/i2c/busses/i2c-designw