RE: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-05 Thread Bela Lubkin
Corey Minyard wrote: > Randy Dunlap wrote: >> Randy Dunlap wrote: >>> Bela Lubkin wrote: Andrew Morton wrote: >> Sometime, please go through the IPMI code looking for all these >> statically-allocated things which are initialised to 0 or NULL >> and remove all those intialisa

Re: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-05 Thread Corey Minyard
Randy Dunlap wrote: > Randy Dunlap wrote: >> Bela Lubkin wrote: >>> Andrew Morton wrote: >>> > Sometime, please go through the IPMI code looking for all these > statically-allocated things which are initialised to 0 or NULL and > remove > all those intialisations? They're unneeded,

Re: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-04 Thread Horst H. von Brand
Randy Dunlap <[EMAIL PROTECTED]> wrote: > Bela Lubkin wrote: > > Andrew Morton wrote: > > > >>> Sometime, please go through the IPMI code looking for all these > >>> statically-allocated things which are initialised to 0 or NULL and remove > >>> all those intialisations? They're unneeded, they inc

Re: [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-03 Thread Andrew Morton
On Sun, 03 Dec 2006 20:35:05 -0600 Corey Minyard <[EMAIL PROTECTED]> wrote: > Do you prefer patches to fold into the existing patches or new versions? Incremental updates are preferred where it makes sense, please. That way we can see what changed. I often will convert updated patches into incr

RE: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-03 Thread Bela Lubkin
Randy Dunlap wrote: > Bela Lubkin wrote: >> Andrew Morton wrote: >> >>> Sometime, please go through the IPMI code looking for all these >>> statically-allocated things which are initialised to 0 or NULL and remove >>> all those intialisations? They're unneeded, they increase the vmlinux >>> image

Re: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-03 Thread Randy Dunlap
Randy Dunlap wrote: Bela Lubkin wrote: Andrew Morton wrote: Sometime, please go through the IPMI code looking for all these statically-allocated things which are initialised to 0 or NULL and remove all those intialisations? They're unneeded, they increase the vmlinux image size and there ar

Re: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-03 Thread Randy Dunlap
Bela Lubkin wrote: Andrew Morton wrote: Sometime, please go through the IPMI code looking for all these statically-allocated things which are initialised to 0 or NULL and remove all those intialisations? They're unneeded, they increase the vmlinux image size and there are quite a number of the

RE: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-03 Thread Bela Lubkin
Andrew Morton wrote: > > Sometime, please go through the IPMI code looking for all these > > statically-allocated things which are initialised to 0 or NULL and remove > > all those intialisations? They're unneeded, they increase the vmlinux > > image size and there are quite a number of them. Th

Re: [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-03 Thread Randy Dunlap
On Sun, 03 Dec 2006 20:35:05 -0600 Corey Minyard wrote: > Andrew Morton wrote: > > On Fri, 1 Dec 2006 22:37:46 -0600 > > Corey Minyard <[EMAIL PROTECTED]> wrote: > > > > > >> +static void (*atca_oem_poweroff_hook)(ipmi_user_t user) = NULL; > >> > > > > Sometime, please go through the IPMI

Re: [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-03 Thread Randy Dunlap
On Sun, 03 Dec 2006 20:35:05 -0600 Corey Minyard wrote: > Andrew Morton wrote: > > On Fri, 1 Dec 2006 22:37:46 -0600 > > Corey Minyard <[EMAIL PROTECTED]> wrote: > > > > > >> +static void (*atca_oem_poweroff_hook)(ipmi_user_t user) = NULL; > >> > > > > Sometime, please go through the IPMI

Re: [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-03 Thread Corey Minyard
Andrew Morton wrote: On Fri, 1 Dec 2006 22:37:46 -0600 Corey Minyard <[EMAIL PROTECTED]> wrote: +static void (*atca_oem_poweroff_hook)(ipmi_user_t user) = NULL; Sometime, please go through the IPMI code looking for all these statically-allocated things which are initialised to 0 or NU

Re: [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-03 Thread Andrew Morton
On Fri, 1 Dec 2006 22:37:46 -0600 Corey Minyard <[EMAIL PROTECTED]> wrote: > +static void (*atca_oem_poweroff_hook)(ipmi_user_t user) = NULL; Sometime, please go through the IPMI code looking for all these statically-allocated things which are initialised to 0 or NULL and remove all those intiali

[PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-01 Thread Corey Minyard
X86 boards generally use ACPI for the power management interactions with the BMC. However, non-x86 boards need some help. This patch adds the help for the Motorola PigeonPoint-based IPMCs. Signed-off-by: Joseph Barnett <[EMAIL PROTECTED]> Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: