Re: [PATCH 8/8] cris-cryptocop: Apply another recommendation from "checkpatch.pl"

2016-08-28 Thread Julia Lawall
On Sun, 28 Aug 2016, SF Markus Elfring wrote: > >> @@ -2276,7 +2277,10 @@ static int cryptocop_job_setup(struct > >> cryptocop_prio_job **pj, struct cryptocop_ > >>(*pj)->iop->ctx_in.saved_data = operation->list_op.inlist; > >>(*pj)->iop->ctx_in.saved_data_buf = > >> op

Re: [PATCH 8/8] cris-cryptocop: Apply another recommendation from "checkpatch.pl"

2016-08-28 Thread SF Markus Elfring
>> @@ -2276,7 +2277,10 @@ static int cryptocop_job_setup(struct >> cryptocop_prio_job **pj, struct cryptocop_ >> (*pj)->iop->ctx_in.saved_data = operation->list_op.inlist; >> (*pj)->iop->ctx_in.saved_data_buf = >> operation->list_op.in_data_buf; >> } else { >> -

Re: [PATCH 8/8] cris-cryptocop: Apply another recommendation from "checkpatch.pl"

2016-08-27 Thread Julia Lawall
On Fri, 26 Aug 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 26 Aug 2016 14:23:06 +0200 > > The script "checkpatch.pl" can point out that assignments should usually > not be performed within condition checks. > Thus move the assignments for a local variable to separate stat

[PATCH 8/8] cris-cryptocop: Apply another recommendation from "checkpatch.pl"

2016-08-26 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 26 Aug 2016 14:23:06 +0200 The script "checkpatch.pl" can point out that assignments should usually not be performed within condition checks. Thus move the assignments for a local variable to separate statements in three functions. Signed-off-by: Markus Elfring -