Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-08-01 Thread Thierry Reding
On Thu, Jul 31, 2014 at 12:06:59PM -0700, Mike Turquette wrote: > Quoting Thierry Reding (2014-07-30 02:34:57) [...] > > Not merging this feature upstream won't stop anybody from implementing > > it as a hack in Android/product kernels either. If it's useful then > > somebody will implement it in w

Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-31 Thread Mikko Perttunen
On 01/08/14 02:08, Mike Turquette wrote: ... That is sensible, and all the more reason that this patch shouldn't implement the rate-change feature within the clock driver. So consider it NAK'd. Also I agree that the per-clock debugfs entries are very useful for RO operations, especially exposing

Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-31 Thread Mike Turquette
Quoting Stephen Warren (2014-07-31 12:53:54) > On 07/31/2014 01:06 PM, Mike Turquette wrote: > > Quoting Thierry Reding (2014-07-30 02:34:57) > >> On Tue, Jul 29, 2014 at 04:14:44PM -0600, Stephen Warren wrote: > >>> On 07/29/2014 02:19 PM, Mike Turquette wrote: > Quoting Mikko Perttunen (2014

Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-31 Thread Stephen Warren
On 07/31/2014 01:06 PM, Mike Turquette wrote: Quoting Thierry Reding (2014-07-30 02:34:57) On Tue, Jul 29, 2014 at 04:14:44PM -0600, Stephen Warren wrote: On 07/29/2014 02:19 PM, Mike Turquette wrote: Quoting Mikko Perttunen (2014-07-29 01:47:35) On 22/07/14 19:57, Stephen Warren wrote: On 0

Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-31 Thread Mike Turquette
Quoting Thierry Reding (2014-07-30 02:34:57) > On Tue, Jul 29, 2014 at 04:14:44PM -0600, Stephen Warren wrote: > > On 07/29/2014 02:19 PM, Mike Turquette wrote: > > >Quoting Mikko Perttunen (2014-07-29 01:47:35) > > >>On 22/07/14 19:57, Stephen Warren wrote: > > >>>On 07/11/2014 08:18 AM, Mikko Per

Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-30 Thread Thierry Reding
On Tue, Jul 29, 2014 at 04:14:44PM -0600, Stephen Warren wrote: > On 07/29/2014 02:19 PM, Mike Turquette wrote: > >Quoting Mikko Perttunen (2014-07-29 01:47:35) > >>On 22/07/14 19:57, Stephen Warren wrote: > >>>On 07/11/2014 08:18 AM, Mikko Perttunen wrote: > +static int emc_debug_rate_set(void

Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-29 Thread Stephen Warren
On 07/29/2014 02:19 PM, Mike Turquette wrote: Quoting Mikko Perttunen (2014-07-29 01:47:35) On 22/07/14 19:57, Stephen Warren wrote: On 07/11/2014 08:18 AM, Mikko Perttunen wrote: +static int emc_debug_rate_set(void *data, u64 rate) +{ +struct tegra_emc *tegra = data; + +return clk_set

Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-29 Thread Mike Turquette
Quoting Mikko Perttunen (2014-07-29 01:47:35) > On 22/07/14 19:57, Stephen Warren wrote: > > On 07/11/2014 08:18 AM, Mikko Perttunen wrote: > >> +static int emc_debug_rate_set(void *data, u64 rate) > >> +{ > >> +struct tegra_emc *tegra = data; > >> + > >> +return clk_set_rate(tegra->hw.clk,

Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-29 Thread Mikko Perttunen
On 22/07/14 19:57, Stephen Warren wrote: On 07/11/2014 08:18 AM, Mikko Perttunen wrote: The driver is currently only tested on Tegra124 Jetson TK1, but should work with other Tegra124 boards, provided that correct EMC tables are provided through the device tree. Older chip models have differing

Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-22 Thread Stephen Warren
On 07/11/2014 08:18 AM, Mikko Perttunen wrote: > The driver is currently only tested on Tegra124 Jetson TK1, but should > work with other Tegra124 boards, provided that correct EMC tables are > provided through the device tree. Older chip models have differing > timing change sequences, so they are

[PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-11 Thread Mikko Perttunen
The driver is currently only tested on Tegra124 Jetson TK1, but should work with other Tegra124 boards, provided that correct EMC tables are provided through the device tree. Older chip models have differing timing change sequences, so they are not currently supported. Signed-off-by: Mikko Perttun