Re: [PATCH 8/25] drivers/dma: fix error return code

2014-01-20 Thread Vinod Koul
On Sun, Dec 29, 2013 at 11:47:23PM +0100, Julia Lawall wrote: > From: Julia Lawall > > Set the return variable to an error code as done elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > ( > i

[PATCH 8/25] drivers/dma: fix error return code

2013-12-29 Thread Julia Lawall
From: Julia Lawall Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret =