Re: [PATCH 6/9] vfio-pci/zdev: fix possible segmentation fault issue

2021-02-02 Thread Cornelia Huck
On Mon, 1 Feb 2021 13:47:57 -0700 Alex Williamson wrote: > On Mon, 1 Feb 2021 12:08:45 -0500 > Matthew Rosato wrote: > > > On 2/1/21 11:52 AM, Cornelia Huck wrote: > > > On Mon, 1 Feb 2021 16:28:25 + > > > Max Gurtovoy wrote: > > > > > >> In case allocation fails, we must behave cor

Re: [PATCH 6/9] vfio-pci/zdev: fix possible segmentation fault issue

2021-02-01 Thread Alex Williamson
On Mon, 1 Feb 2021 12:08:45 -0500 Matthew Rosato wrote: > On 2/1/21 11:52 AM, Cornelia Huck wrote: > > On Mon, 1 Feb 2021 16:28:25 + > > Max Gurtovoy wrote: > > > >> In case allocation fails, we must behave correctly and exit with error. > >> > >> Signed-off-by: Max Gurtovoy > > > > F

Re: [PATCH 6/9] vfio-pci/zdev: fix possible segmentation fault issue

2021-02-01 Thread Matthew Rosato
On 2/1/21 11:52 AM, Cornelia Huck wrote: On Mon, 1 Feb 2021 16:28:25 + Max Gurtovoy wrote: In case allocation fails, we must behave correctly and exit with error. Signed-off-by: Max Gurtovoy Fixes: e6b817d4b821 ("vfio-pci/zdev: Add zPCI capabilities to VFIO_DEVICE_GET_INFO") Reviewed

Re: [PATCH 6/9] vfio-pci/zdev: fix possible segmentation fault issue

2021-02-01 Thread Cornelia Huck
On Mon, 1 Feb 2021 16:28:25 + Max Gurtovoy wrote: > In case allocation fails, we must behave correctly and exit with error. > > Signed-off-by: Max Gurtovoy Fixes: e6b817d4b821 ("vfio-pci/zdev: Add zPCI capabilities to VFIO_DEVICE_GET_INFO") Reviewed-by: Cornelia Huck I think this shoul

[PATCH 6/9] vfio-pci/zdev: fix possible segmentation fault issue

2021-02-01 Thread Max Gurtovoy
In case allocation fails, we must behave correctly and exit with error. Signed-off-by: Max Gurtovoy --- drivers/vfio/pci/vfio_pci_zdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/vfio/pci/vfio_pci_zdev.c b/drivers/vfio/pci/vfio_pci_zdev.c index 175096fcd902..e9ef4239ef7a 10