Re: [PATCH 6/9] firewire: fw-sbp2: don't add scsi_device twice

2008-02-12 Thread Stefan Richter
Stefan Richter wrote: > Jarod Wilson wrote: >> Was the spurious __scsi_add_device simply failing, or was it causing >> other problems as well? > SCSI core looks up whether the scsi_target and the scsi_device already > exist. If so, __scsi_add_device succeeds (there should also be a log > message

Re: [PATCH 6/9] firewire: fw-sbp2: don't add scsi_device twice

2008-02-11 Thread Stefan Richter
Jarod Wilson wrote: > Stefan Richter wrote: >> When a reconnect failed but re-login succeeded, __scsi_add_device was >> called again. >> >> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > > Was the spurious __scsi_add_device simply failing, or was it causing > other problems as well? I can't r

Re: [PATCH 6/9] firewire: fw-sbp2: don't add scsi_device twice

2008-02-11 Thread Jarod Wilson
Stefan Richter wrote: When a reconnect failed but re-login succeeded, __scsi_add_device was called again. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> Was the spurious __scsi_add_device simply failing, or was it causing other problems as well? I can't remember if I've hit that or not. In

[PATCH 6/9] firewire: fw-sbp2: don't add scsi_device twice

2008-02-03 Thread Stefan Richter
When a reconnect failed but re-login succeeded, __scsi_add_device was called again. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-sbp2.c |6 ++ 1 file changed, 6 insertions(+) Index: linux/drivers/firewire/fw-sbp2.c