Re: [PATCH 6/9] efi: Add EFI signature data types

2016-11-21 Thread Ard Biesheuvel
On 17 November 2016 at 09:44, David Howells wrote: > Mat Martineau wrote: > >> The trailing ';' on EFI_CERT_X509_SHA256_GUID could trip someone up later. As >> long as you're fixing that, the spaces before the closing parens are >> inconsistent with the other GUID definitions in this file. > > Fi

Re: [PATCH 6/9] efi: Add EFI signature data types

2016-11-17 Thread David Howells
Mat Martineau wrote: > The trailing ';' on EFI_CERT_X509_SHA256_GUID could trip someone up later. As > long as you're fixing that, the spaces before the closing parens are > inconsistent with the other GUID definitions in this file. Fixed, thanks. David

Re: [PATCH 6/9] efi: Add EFI signature data types

2016-11-16 Thread Mat Martineau
David, On Wed, 16 Nov 2016, David Howells wrote: From: Dave Howells Add the data types that are used for containing hashes, keys and certificates for cryptographic verification along with their corresponding type GUIDs. Signed-off-by: David Howells --- include/linux/efi.h | 24 +

[PATCH 6/9] efi: Add EFI signature data types

2016-11-16 Thread David Howells
From: Dave Howells Add the data types that are used for containing hashes, keys and certificates for cryptographic verification along with their corresponding type GUIDs. Signed-off-by: David Howells --- include/linux/efi.h | 24 1 file changed, 24 insertions(+) di