Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-11-03 Thread Mark Brown
On Mon, Nov 03, 2014 at 01:07:02PM +0100, Krzysztof Kozlowski wrote: > On pią, 2014-10-31 at 10:32 +, Mark Brown wrote: > > We could always add a callback for the driver to handle any custom > > properties... one of the advantages of an OS like Linux is that we can > > improve the core code.

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-11-03 Thread Krzysztof Kozlowski
On pią, 2014-10-31 at 10:32 +, Mark Brown wrote: > On Fri, Oct 31, 2014 at 08:51:38AM +0100, Krzysztof Kozlowski wrote: > > > However new DT style parsing (regulator_of_get_init_data()) does the > > basic parsing stuff and this removes a lot of code from driver. The > > driver no longer parses

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-31 Thread Alexandre Courbot
On Fri, Oct 31, 2014 at 4:51 PM, Krzysztof Kozlowski wrote: > On pią, 2014-10-31 at 12:31 +0900, Alexandre Courbot wrote: >> On Fri, Oct 31, 2014 at 12:03 AM, Krzysztof Kozlowski >> wrote: >> > On czw, 2014-10-30 at 22:56 +0900, Alexandre Courbot wrote: >> >> Hi, and thanks for bringing this issu

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-31 Thread Mark Brown
On Fri, Oct 31, 2014 at 12:45:47PM +0100, Krzysztof Kozlowski wrote: > Then I'll add it. > Mark, what device should be assigned to "config.dev" during registration > of regulators? The regulator driver's device or its parent (MFD main > driver)? > Various drivers do this differently. Normally t

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-31 Thread Krzysztof Kozlowski
On pią, 2014-10-31 at 10:32 +, Mark Brown wrote: > On Fri, Oct 31, 2014 at 08:51:38AM +0100, Krzysztof Kozlowski wrote: > > > However new DT style parsing (regulator_of_get_init_data()) does the > > basic parsing stuff and this removes a lot of code from driver. The > > driver no longer parses

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-31 Thread Mark Brown
On Fri, Oct 31, 2014 at 08:51:38AM +0100, Krzysztof Kozlowski wrote: > However new DT style parsing (regulator_of_get_init_data()) does the > basic parsing stuff and this removes a lot of code from driver. The > driver no longer parses all regulaotrs but the regulator core does it. > Unfortunately

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-31 Thread Krzysztof Kozlowski
On pią, 2014-10-31 at 12:31 +0900, Alexandre Courbot wrote: > On Fri, Oct 31, 2014 at 12:03 AM, Krzysztof Kozlowski > wrote: > > On czw, 2014-10-30 at 22:56 +0900, Alexandre Courbot wrote: > >> Hi, and thanks for bringing this issue to us! > >> > >> On Wed, Oct 29, 2014 at 7:49 PM, Javier Martinez

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-30 Thread Alexandre Courbot
On Fri, Oct 31, 2014 at 12:03 AM, Krzysztof Kozlowski wrote: > On czw, 2014-10-30 at 22:56 +0900, Alexandre Courbot wrote: >> Hi, and thanks for bringing this issue to us! >> >> On Wed, Oct 29, 2014 at 7:49 PM, Javier Martinez Canillas >> wrote: >> > [adding Linus and Alexandre to the cc list] >>

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-30 Thread Krzysztof Kozlowski
On czw, 2014-10-30 at 22:56 +0900, Alexandre Courbot wrote: > Hi, and thanks for bringing this issue to us! > > On Wed, Oct 29, 2014 at 7:49 PM, Javier Martinez Canillas > wrote: > > [adding Linus and Alexandre to the cc list] > > > > Hello Krzysztof, > > > > On 10/29/2014 11:42 AM, Krzysztof Koz

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-30 Thread Alexandre Courbot
Hi, and thanks for bringing this issue to us! On Wed, Oct 29, 2014 at 7:49 PM, Javier Martinez Canillas wrote: > [adding Linus and Alexandre to the cc list] > > Hello Krzysztof, > > On 10/29/2014 11:42 AM, Krzysztof Kozlowski wrote: >> On wto, 2014-10-28 at 13:11 +0100, Krzysztof Kozlowski wrote:

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-29 Thread Javier Martinez Canillas
[adding Linus and Alexandre to the cc list] Hello Krzysztof, On 10/29/2014 11:42 AM, Krzysztof Kozlowski wrote: > On wto, 2014-10-28 at 13:11 +0100, Krzysztof Kozlowski wrote: >> On wto, 2014-10-28 at 09:52 +0100, Krzysztof Kozlowski wrote: >> > On pon, 2014-10-27 at 21:03 +0100, Javier Martinez

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-29 Thread Krzysztof Kozlowski
On wto, 2014-10-28 at 13:11 +0100, Krzysztof Kozlowski wrote: > On wto, 2014-10-28 at 09:52 +0100, Krzysztof Kozlowski wrote: > > On pon, 2014-10-27 at 21:03 +0100, Javier Martinez Canillas wrote: > > > Hello Krzysztof, > > > > > > On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote: > > > > @@ -85,

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-28 Thread Krzysztof Kozlowski
On wto, 2014-10-28 at 09:52 +0100, Krzysztof Kozlowski wrote: > On pon, 2014-10-27 at 21:03 +0100, Javier Martinez Canillas wrote: > > Hello Krzysztof, > > > > On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote: > > > @@ -85,6 +91,9 @@ struct max77686_data { > > > struct max77686_regulator_data *

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-28 Thread Krzysztof Kozlowski
On pon, 2014-10-27 at 21:03 +0100, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote: > > @@ -85,6 +91,9 @@ struct max77686_data { > > struct max77686_regulator_data *regulators; > > int num_regulators; > > > > + /* Array of size n

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote: > @@ -85,6 +91,9 @@ struct max77686_data { > struct max77686_regulator_data *regulators; > int num_regulators; > > + /* Array of size num_regulators with GPIOs for external control. */ > + int *ext_control_gp

[PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-27 Thread Krzysztof Kozlowski
Add control over GPIO for regulators supporting this: LDO20, LDO21, LDO22, buck8 and buck9. This is needed for proper (and full) configuration of the Maxim 77686 PMIC without creating redundant 'regulator-fixed' entries. Signed-off-by: Krzysztof Kozlowski --- drivers/regulator/max77686.c | 101