Re: [PATCH 6/8] drm/sun4i: sun4i_layer: Wire in the frontend

2017-12-16 Thread kbuild test robot
Hi Maxime, I love your patch! Yet something to improve: [auto build test ERROR on ] url: https://github.com/0day-ci/linux/commits/Maxime-Ripard/drm-sun4i-Support-the-Display-Engine-frontend/20171216-122702 base: config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-g

Re: [PATCH 6/8] drm/sun4i: sun4i_layer: Wire in the frontend

2017-12-14 Thread Maxime Ripard
Hi, On Wed, Dec 13, 2017 at 05:23:04PM +0100, Thomas van Kleef wrote: > I wondered if the following is still valid? > In file sun4i_layer.c, func sun4i_layers_init > > -- > /* > * The hardware is a bit unusual here. > * > * Even though it suppor

Re: [PATCH 6/8] drm/sun4i: sun4i_layer: Wire in the frontend

2017-12-13 Thread Thomas van Kleef
On 13-12-17 16:33, Maxime Ripard wrote: > Now that we have a driver, we can make use of it. This is done by > adding a flag to our custom plane state that will trigger whether we should > use the frontend on that particular plane or not. > > The rest is just plumbing to set up the backend to not

Re: [PATCH 6/8] drm/sun4i: sun4i_layer: Wire in the frontend

2017-12-13 Thread Neil Armstrong
On 13/12/2017 16:33, Maxime Ripard wrote: > Now that we have a driver, we can make use of it. This is done by > adding a flag to our custom plane state that will trigger whether we should > use the frontend on that particular plane or not. > > The rest is just plumbing to set up the backend to not

[PATCH 6/8] drm/sun4i: sun4i_layer: Wire in the frontend

2017-12-13 Thread Maxime Ripard
Now that we have a driver, we can make use of it. This is done by adding a flag to our custom plane state that will trigger whether we should use the frontend on that particular plane or not. The rest is just plumbing to set up the backend to not perform the DMA but receive its data from the front