Re: [PATCH 6/8] IB/hns: Replace counting semaphore event_sem with wait condition

2016-10-19 Thread Arnd Bergmann
On Tuesday, October 18, 2016 10:46:45 AM CEST Binoy Jayan wrote: > Thank you for replying for the questions. I''ll look for alternatives > for patches 6,7 and 8 and resend the series. Ok, thanks! I also looked at patch 8 some more and noticed that those four functions all do the exact same sequen

Re: [PATCH 6/8] IB/hns: Replace counting semaphore event_sem with wait condition

2016-10-17 Thread Binoy Jayan
On 18 October 2016 at 01:59, Arnd Bergmann wrote: > On Monday, October 17, 2016 10:01:00 PM CEST Binoy Jayan wrote: >> --- a/drivers/infiniband/hw/hns/hns_roce_cmd.c >> +++ b/drivers/infiniband/hw/hns/hns_roce_cmd.c >> @@ -248,10 +248,14 @@ static int hns_roce_cmd_mbox_wait(struct hns_roce_dev >>

Re: [PATCH 6/8] IB/hns: Replace counting semaphore event_sem with wait condition

2016-10-17 Thread Arnd Bergmann
On Monday, October 17, 2016 10:01:00 PM CEST Binoy Jayan wrote: > --- a/drivers/infiniband/hw/hns/hns_roce_cmd.c > +++ b/drivers/infiniband/hw/hns/hns_roce_cmd.c > @@ -248,10 +248,14 @@ static int hns_roce_cmd_mbox_wait(struct hns_roce_dev > *hr_dev, u64 in_param, > { > int ret = 0; > >

Re: [PATCH 6/8] IB/hns: Replace counting semaphore event_sem with wait condition

2016-10-17 Thread Christoph Hellwig
On Mon, Oct 17, 2016 at 10:01:00PM +0530, Binoy Jayan wrote: > Counting semaphores are going away in the future, so replace the semaphore > hns_roce_cmdq::event_sem with an open-coded implementation. Sorry, but no. Using a proper semaphore abstraction is always better than open coding it. While

[PATCH 6/8] IB/hns: Replace counting semaphore event_sem with wait condition

2016-10-17 Thread Binoy Jayan
Counting semaphores are going away in the future, so replace the semaphore hns_roce_cmdq::event_sem with an open-coded implementation. Signed-off-by: Binoy Jayan --- drivers/infiniband/hw/hns/hns_roce_cmd.c| 16 drivers/infiniband/hw/hns/hns_roce_device.h | 3 ++- include/r