Re: [PATCH 6/7] perf kvm: move perf_kvm__mmap_read into session utils

2014-06-23 Thread Stanislav Fomichev
> Stanislav: are you seeing out of order timestamp errors or just trying to > reuse the live code from perf-kvm? Yes, I need events ordering, otherwise I see: 1. pagefault event 2. comm and mmap events for the process above Hence I have to print cryptic messages without any details. As Arnaldo po

Re: [PATCH 6/7] perf kvm: move perf_kvm__mmap_read into session utils

2014-06-23 Thread David Ahern
On 6/20/14, 8:44 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jun 20, 2014 at 02:49:48PM +0400, Stanislav Fomichev escreveu: It will be reused by perf trace in the following commit. I know this is needed, but one of the goals when I started builtin-trace was not to use perf_session at all, as i

Re: [PATCH 6/7] perf kvm: move perf_kvm__mmap_read into session utils

2014-06-20 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 20, 2014 at 07:07:02PM +0400, Stanislav Fomichev escreveu: > > I.e. what we need from perf_session is just the ordered_samples bits, > > perhaps in its current form, perhaps rewritten, see (renewed) discussion > > involving David Ahern and Jiri Olsa. > Do you mean you want to pull (at s

Re: [PATCH 6/7] perf kvm: move perf_kvm__mmap_read into session utils

2014-06-20 Thread Stanislav Fomichev
> I.e. what we need from perf_session is just the ordered_samples bits, > perhaps in its current form, perhaps rewritten, see (renewed) discussion > involving David Ahern and Jiri Olsa. Do you mean you want to pull (at some point) Jiri's patches and want to use just event ordering part in perf trac

Re: [PATCH 6/7] perf kvm: move perf_kvm__mmap_read into session utils

2014-06-20 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 20, 2014 at 02:49:48PM +0400, Stanislav Fomichev escreveu: > It will be reused by perf trace in the following commit. I know this is needed, but one of the goals when I started builtin-trace was not to use perf_session at all, as it initially was just about the live mode. record/repla

[PATCH 6/7] perf kvm: move perf_kvm__mmap_read into session utils

2014-06-20 Thread Stanislav Fomichev
It will be reused by perf trace in the following commit. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-kvm.c | 88 +++ tools/perf/util/session.c | 85 + tools/perf/util/session.h | 5 +++ 3 files