Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting

2012-07-09 Thread Greg Thelen
On Thu, Jun 28 2012, Sha Zhengju wrote: > From: Sha Zhengju > > Similar to dirty page, we add per cgroup writeback pages accounting. The lock > rule still is: > mem_cgroup_begin_update_page_stat() > modify page WRITEBACK stat > mem_cgroup_update_page_stat() > mem_cgroup_en

Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting

2012-07-08 Thread Fengguang Wu
On Mon, Jul 09, 2012 at 01:22:54PM +0800, Sha Zhengju wrote: > On 07/09/2012 12:18 PM, Kamezawa Hiroyuki wrote: > >(2012/07/09 13:14), Fengguang Wu wrote: > >>On Mon, Jul 09, 2012 at 11:36:11AM +0800, Sha Zhengju wrote: > >>>On 07/08/2012 10:53 PM, Fengguang Wu wrote: > >@@ -2245,7 +2252,10 @@

Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting

2012-07-08 Thread Fengguang Wu
> >>>Where is the MEM_CGROUP_STAT_FILE_WRITEBACK increased? > >>> > >>It's in account_page_writeback(). > >> > >> void account_page_writeback(struct page *page) > >> { > >>+ mem_cgroup_inc_page_stat(page, MEM_CGROUP_STAT_FILE_WRITEBACK); > >>inc_zone_page_state(page, NR_WRITEBACK); > >> }

Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting

2012-07-08 Thread Sha Zhengju
On 07/09/2012 12:18 PM, Kamezawa Hiroyuki wrote: (2012/07/09 13:14), Fengguang Wu wrote: On Mon, Jul 09, 2012 at 11:36:11AM +0800, Sha Zhengju wrote: On 07/08/2012 10:53 PM, Fengguang Wu wrote: @@ -2245,7 +2252,10 @@ int test_set_page_writeback(struct page *page) { struct address_space

Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting

2012-07-08 Thread Sha Zhengju
On 07/09/2012 12:14 PM, Fengguang Wu wrote: On Mon, Jul 09, 2012 at 11:36:11AM +0800, Sha Zhengju wrote: On 07/08/2012 10:53 PM, Fengguang Wu wrote: @@ -2245,7 +2252,10 @@ int test_set_page_writeback(struct page *page) { struct address_space *mapping = page_mapping(page); int

Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting

2012-07-08 Thread Kamezawa Hiroyuki
(2012/07/09 13:14), Fengguang Wu wrote: On Mon, Jul 09, 2012 at 11:36:11AM +0800, Sha Zhengju wrote: On 07/08/2012 10:53 PM, Fengguang Wu wrote: @@ -2245,7 +2252,10 @@ int test_set_page_writeback(struct page *page) { struct address_space *mapping = page_mapping(page); int ret;

Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting

2012-07-08 Thread Fengguang Wu
On Mon, Jul 09, 2012 at 11:36:11AM +0800, Sha Zhengju wrote: > On 07/08/2012 10:53 PM, Fengguang Wu wrote: > >>@@ -2245,7 +2252,10 @@ int test_set_page_writeback(struct page *page) > >> { > >>struct address_space *mapping = page_mapping(page); > >>int ret; > >>+ bool locked; > >>+ unsi

Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting

2012-07-08 Thread Sha Zhengju
On 07/08/2012 10:53 PM, Fengguang Wu wrote: @@ -2245,7 +2252,10 @@ int test_set_page_writeback(struct page *page) { struct address_space *mapping = page_mapping(page); int ret; + bool locked; + unsigned long flags; + mem_cgroup_begin_update_page_stat(page,&loc

Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting

2012-07-08 Thread Fengguang Wu
On Mon, Jul 09, 2012 at 01:01:00AM +0200, Johannes Weiner wrote: > On Sun, Jul 08, 2012 at 10:44:59PM +0800, Fengguang Wu wrote: > > On Tue, Jul 03, 2012 at 03:31:26PM +0900, KAMEZAWA Hiroyuki wrote: > > > (2012/06/28 20:05), Sha Zhengju wrote: > > > > From: Sha Zhengju > > > > > > > > Similar to

Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting

2012-07-08 Thread Johannes Weiner
On Sun, Jul 08, 2012 at 10:44:59PM +0800, Fengguang Wu wrote: > On Tue, Jul 03, 2012 at 03:31:26PM +0900, KAMEZAWA Hiroyuki wrote: > > (2012/06/28 20:05), Sha Zhengju wrote: > > > From: Sha Zhengju > > > > > > Similar to dirty page, we add per cgroup writeback pages accounting. The > > > lock >

Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting

2012-07-08 Thread Fengguang Wu
> @@ -2245,7 +2252,10 @@ int test_set_page_writeback(struct page *page) > { > struct address_space *mapping = page_mapping(page); > int ret; > + bool locked; > + unsigned long flags; > > + mem_cgroup_begin_update_page_stat(page, &locked, &flags); > if (mapping) { >

Re: [PATCH 6/7] memcg: add per cgroup writeback pages accounting

2012-07-08 Thread Fengguang Wu
On Tue, Jul 03, 2012 at 03:31:26PM +0900, KAMEZAWA Hiroyuki wrote: > (2012/06/28 20:05), Sha Zhengju wrote: > > From: Sha Zhengju > > > > Similar to dirty page, we add per cgroup writeback pages accounting. The > > lock > > rule still is: > > mem_cgroup_begin_update_page_stat() > > modif