Re: [PATCH 6/7] exec: Move most of setup_new_exec into flush_old_exec

2020-05-07 Thread Kees Cook
On Thu, May 07, 2020 at 04:51:13PM -0500, Eric W. Biederman wrote: > I intend to the following text to the changelog. At this point I > believe I have read through everything and nothing raises any concerns > for me: > > --- text begin --- > > To see why it is safe to move this code please note

Re: [PATCH 6/7] exec: Move most of setup_new_exec into flush_old_exec

2020-05-07 Thread Eric W. Biederman
Kees Cook writes: > On Tue, May 05, 2020 at 02:45:33PM -0500, Eric W. Biederman wrote: >> >> The current idiom for the callers is: >> >> flush_old_exec(bprm); >> set_personality(...); >> setup_new_exec(bprm); >> >> In 2010 Linus split flush_old_exec into flush_old_exec and >> setup_new_exec.

Re: [PATCH 6/7] exec: Move most of setup_new_exec into flush_old_exec

2020-05-07 Thread Eric W. Biederman
Kees Cook writes: > On Wed, May 06, 2020 at 09:57:10AM -0500, Eric W. Biederman wrote: >> Kees Cook writes: >> >> > On Tue, May 05, 2020 at 02:45:33PM -0500, Eric W. Biederman wrote: >> >> >> >> The current idiom for the callers is: >> >> >> >> flush_old_exec(bprm); >> >> set_personality(...)

Re: [PATCH 6/7] exec: Move most of setup_new_exec into flush_old_exec

2020-05-06 Thread Kees Cook
On Wed, May 06, 2020 at 09:57:10AM -0500, Eric W. Biederman wrote: > Kees Cook writes: > > > On Tue, May 05, 2020 at 02:45:33PM -0500, Eric W. Biederman wrote: > >> > >> The current idiom for the callers is: > >> > >> flush_old_exec(bprm); > >> set_personality(...); > >> setup_new_exec(bprm); >

Re: [PATCH 6/7] exec: Move most of setup_new_exec into flush_old_exec

2020-05-06 Thread Eric W. Biederman
Kees Cook writes: > On Tue, May 05, 2020 at 02:45:33PM -0500, Eric W. Biederman wrote: >> >> The current idiom for the callers is: >> >> flush_old_exec(bprm); >> set_personality(...); >> setup_new_exec(bprm); >> >> In 2010 Linus split flush_old_exec into flush_old_exec and >> setup_new_exec.

Re: [PATCH 6/7] exec: Move most of setup_new_exec into flush_old_exec

2020-05-05 Thread Kees Cook
On Tue, May 05, 2020 at 02:45:33PM -0500, Eric W. Biederman wrote: > > The current idiom for the callers is: > > flush_old_exec(bprm); > set_personality(...); > setup_new_exec(bprm); > > In 2010 Linus split flush_old_exec into flush_old_exec and > setup_new_exec. With the intention that setup_n

[PATCH 6/7] exec: Move most of setup_new_exec into flush_old_exec

2020-05-05 Thread Eric W. Biederman
The current idiom for the callers is: flush_old_exec(bprm); set_personality(...); setup_new_exec(bprm); In 2010 Linus split flush_old_exec into flush_old_exec and setup_new_exec. With the intention that setup_new_exec be what is called after the processes new personality is set. Move the code