Re: [PATCH 6/6] workqueue: deprecate WQ_NON_REENTRANT

2012-08-14 Thread Tejun Heo
Hello, On Tue, Aug 14, 2012 at 07:24:59PM +0200, Marc Dietrich wrote: > the nvec driver had its own workqueue because we found that it reduced some > timimg induced protocol errors. I just tested your patch which uses the > system > workqueue and I failed to reproduce these protocol errors unde

Re: [PATCH 6/6] workqueue: deprecate WQ_NON_REENTRANT

2012-08-14 Thread Marc Dietrich
Hi Tejun, On Monday 13 August 2012 18:49:46 Tejun Heo wrote: > WQ_NON_REENTRANT is now spurious. Make alloc_workqueue() trigger > WARN_ON() if the flag is specified and drop it from all in-kernel > users. > > If you're cc'd and wondering what's going on: Now all workqueues are > non-reentrant, s

[PATCH 6/6] workqueue: deprecate WQ_NON_REENTRANT

2012-08-13 Thread Tejun Heo
WQ_NON_REENTRANT is now spurious. Make alloc_workqueue() trigger WARN_ON() if the flag is specified and drop it from all in-kernel users. If you're cc'd and wondering what's going on: Now all workqueues are non-reentrant, so there's no reason to use WQ_NON_REENTRANT. Some of the conversions in t