Re: [PATCH 6/6] vfs: change inode times to use struct timespec64

2018-05-16 Thread Arnd Bergmann
On Mon, May 14, 2018 at 2:23 PM, Deepa Dinamani wrote: > On Mon, May 14, 2018 at 10:53 AM, Kees Cook wrote: >> On Mon, May 14, 2018 at 10:25 AM, Deepa Dinamani >> wrote: >>> On Mon, May 14, 2018 at 9:30 AM, Kees Cook wrote: >> >> Can we do something like: >> >> #if __BITS_PER_LONG == 64 >> # d

Re: [PATCH 6/6] vfs: change inode times to use struct timespec64

2018-05-14 Thread Kees Cook
On Mon, May 14, 2018 at 11:23 AM, Deepa Dinamani wrote: > On Mon, May 14, 2018 at 10:53 AM, Kees Cook wrote: >> On Mon, May 14, 2018 at 10:25 AM, Deepa Dinamani >> wrote: >>> On Mon, May 14, 2018 at 9:30 AM, Kees Cook wrote: On Sun, May 13, 2018 at 9:05 PM, Deepa Dinamani wrote: >>

Re: [PATCH 6/6] vfs: change inode times to use struct timespec64

2018-05-14 Thread Deepa Dinamani
On Mon, May 14, 2018 at 10:53 AM, Kees Cook wrote: > On Mon, May 14, 2018 at 10:25 AM, Deepa Dinamani > wrote: >> On Mon, May 14, 2018 at 9:30 AM, Kees Cook wrote: >>> On Sun, May 13, 2018 at 9:05 PM, Deepa Dinamani >>> wrote: Kees mentioned that he wants to merge a patch to pstore that

Re: [PATCH 6/6] vfs: change inode times to use struct timespec64

2018-05-14 Thread Kees Cook
On Mon, May 14, 2018 at 10:25 AM, Deepa Dinamani wrote: > On Mon, May 14, 2018 at 9:30 AM, Kees Cook wrote: >> On Sun, May 13, 2018 at 9:05 PM, Deepa Dinamani >> wrote: >>> Kees mentioned that he wants to merge a patch to pstore that changes >>> it to use timespec64 internally for 4.17: >>> htt

Re: [PATCH 6/6] vfs: change inode times to use struct timespec64

2018-05-14 Thread Deepa Dinamani
On Mon, May 14, 2018 at 9:30 AM, Kees Cook wrote: > On Sun, May 13, 2018 at 9:05 PM, Deepa Dinamani > wrote: >> Kees mentioned that he wants to merge a patch to pstore that changes >> it to use timespec64 internally for 4.17: >> https://lkml.org/lkml/2018/5/13/3 > > I'm still working on a v2 for

Re: [PATCH 6/6] vfs: change inode times to use struct timespec64

2018-05-14 Thread Kees Cook
On Sun, May 13, 2018 at 9:05 PM, Deepa Dinamani wrote: > Kees mentioned that he wants to merge a patch to pstore that changes > it to use timespec64 internally for 4.17: > https://lkml.org/lkml/2018/5/13/3 I'm still working on a v2 for pstore. What is the correct cross-architecture format string

Re: [PATCH 6/6] vfs: change inode times to use struct timespec64

2018-05-13 Thread Deepa Dinamani
Al, Are you ok with this approach to changing vfs timestamps? Kees mentioned that he wants to merge a patch to pstore that changes it to use timespec64 internally for 4.17: https://lkml.org/lkml/2018/5/13/3 I'm not sure how we usually merge such flag day patches. Should this be targeted for 4.17

Re: [PATCH 6/6] vfs: change inode times to use struct timespec64

2018-05-11 Thread Kees Cook
On Fri, May 11, 2018 at 9:59 PM, Deepa Dinamani wrote: > diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c > index 5fcb845b9fec..fb681d302bb3 100644 > --- a/fs/pstore/inode.c > +++ b/fs/pstore/inode.c > @@ -392,7 +392,7 @@ int pstore_mkfile(struct dentry *root, struct > pstore_record *record) >

[PATCH 6/6] vfs: change inode times to use struct timespec64

2018-05-11 Thread Deepa Dinamani
struct timespec is not y2038 safe. Transition vfs to use y2038 safe struct timespec64 instead. The change was made with the help of the following cocinelle script. This catches about 80% of the changes. All the header file and logic changes are included in the first 5 rules. The rest are trivial s