Re: [PATCH 6/6] udf: super.c reorganization

2008-02-10 Thread Marcin Slusarz
On Wed, Feb 06, 2008 at 12:09:36PM +0100, Jan Kara wrote: > On Tue 05-02-08 20:34:49, Marcin Slusarz wrote: > > On Tue, Feb 05, 2008 at 05:22:19PM +0100, Jan Kara wrote: > > > Actually, the loop below would be even more readable it you did: > > > > > > if (map->s_partition_num == le16_to_cpu(p

Re: [PATCH 6/6] udf: super.c reorganization

2008-02-06 Thread Jan Kara
On Tue 05-02-08 20:34:49, Marcin Slusarz wrote: > On Tue, Feb 05, 2008 at 05:22:19PM +0100, Jan Kara wrote: > > Actually, the loop below would be even more readable it you did: > > > > if (map->s_partition_num == le16_to_cpu(p->partitionNumber)) > > break; > > And do the work after we ex

Re: [PATCH 6/6] udf: super.c reorganization

2008-02-05 Thread Marcin Slusarz
On Tue, Feb 05, 2008 at 05:22:19PM +0100, Jan Kara wrote: > Actually, the loop below would be even more readable it you did: > > if (map->s_partition_num == le16_to_cpu(p->partitionNumber)) > break; > And do the work after we exit from the loop. > > > > for (i = 0; i < sbi->s_parti

Re: [PATCH 6/6] udf: super.c reorganization

2008-02-05 Thread Jan Kara
On Sun 03-02-08 19:42:38, Marcin Slusarz wrote: > reorganize few code blocks in super.c which > were needlessly indented (and hard to read): > > so change from: > rettype fun() > { > init; > if (sth) { > long block of code; > } > } > > to: > rettype fun() > { >

[PATCH 6/6] udf: super.c reorganization

2008-02-03 Thread Marcin Slusarz
reorganize few code blocks in super.c which were needlessly indented (and hard to read): so change from: rettype fun() { init; if (sth) { long block of code; } } to: rettype fun() { init; if (!sth) return; long block