Re: [PATCH 6/6] qlcnic_dcb.c : possible division by zero.

2015-02-26 Thread Sergei Shtylyov
Hello. On 02/26/2015 12:56 AM, Ameen Ali wrote: Whenever there is a division it is usually worthwhile to add some belt'n'braces code to ensure that cnt != 0, otherwise a machine signal can occur. Signed-off-by : Ameen Ali --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c | 2 +- 1 file

[PATCH 6/6] qlcnic_dcb.c : possible division by zero.

2015-02-25 Thread Ameen Ali
Whenever there is a division it is usually worthwhile to add some belt'n'braces code to ensure that cnt != 0, otherwise a machine signal can occur. Signed-off-by : Ameen Ali --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

Re: [PATCH 6/6] qlcnic_dcb.c : possible division by zero.

2015-02-25 Thread David Miller
From: Ameen Ali Date: Wed, 25 Feb 2015 23:56:43 +0200 > @@ -822,7 +822,7 @@ qlcnic_dcb_get_pg_tc_cfg_tx(struct net_device *netdev, > int tc, u8 *prio, > if (temp->valid && (pg == temp->pgid)) > cnt++; > } > - > + if(cnt != 0) > tc_cfg->bwg_perc

[PATCH 6/6] qlcnic_dcb.c : possible division by zero.

2015-02-25 Thread Ameen Ali
Whenever there is a division it is usually worthwhile to add some belt'n'braces code to ensure that cnt != 0, otherwise a machine signal can occur. Signed-off-by : Ameen Ali --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr