Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal

2015-10-28 Thread Jon Hunter
On 28/10/15 06:53, Vinod Koul wrote: > On Fri, Oct 16, 2015 at 11:57:02AM +0100, Jon Hunter wrote: > How about just calling free_irq()? That's how you'd typically handle this. Yes, however, the interrupt is requested by devm_request_irq(). I guess I could call devm_free_irq() he

Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal

2015-10-27 Thread Vinod Koul
On Fri, Oct 16, 2015 at 11:57:02AM +0100, Jon Hunter wrote: > >>> How about just calling free_irq()? That's how you'd typically handle this. > >> > >> Yes, however, the interrupt is requested by devm_request_irq(). I guess > >> I could call devm_free_irq() here? > > > > Just use request_irq() inst

Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal

2015-10-16 Thread Jon Hunter
On 16/10/15 11:40, Lars-Peter Clausen wrote: > On 10/16/2015 11:29 AM, Jon Hunter wrote: >> >> On 16/10/15 09:53, Lars-Peter Clausen wrote: >>> On 10/16/2015 10:25 AM, Jon Hunter wrote: On driver removal, before killing any tasklets, ensure that the channel interrupts are disabled so tha

Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal

2015-10-16 Thread Lars-Peter Clausen
On 10/16/2015 11:29 AM, Jon Hunter wrote: > > On 16/10/15 09:53, Lars-Peter Clausen wrote: >> On 10/16/2015 10:25 AM, Jon Hunter wrote: >>> On driver removal, before killing any tasklets, ensure that the channel >>> interrupts are disabled so that the tasklet will not try to run during >>> or afte

Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal

2015-10-16 Thread Jon Hunter
On 16/10/15 09:53, Lars-Peter Clausen wrote: > On 10/16/2015 10:25 AM, Jon Hunter wrote: >> On driver removal, before killing any tasklets, ensure that the channel >> interrupts are disabled so that the tasklet will not try to run during >> or after the removal of the driver. >> >> Signed-off-by:

Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal

2015-10-16 Thread Lars-Peter Clausen
On 10/16/2015 10:25 AM, Jon Hunter wrote: > On driver removal, before killing any tasklets, ensure that the channel > interrupts are disabled so that the tasklet will not try to run during > or after the removal of the driver. > > Signed-off-by: Jon Hunter > --- > drivers/dma/tegra20-apb-dma.c |

[PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal

2015-10-16 Thread Jon Hunter
On driver removal, before killing any tasklets, ensure that the channel interrupts are disabled so that the tasklet will not try to run during or after the removal of the driver. Signed-off-by: Jon Hunter --- drivers/dma/tegra20-apb-dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drive