Re: [PATCH 6/6] dmaengine: ste_dma40: fix error return code

2014-11-28 Thread Linus Walleij
On Sat, Nov 22, 2014 at 3:39 PM, Julia Lawall wrote: > From: Julia Lawall > > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > identifier ret; expression e1,e2; > @@ > ( >

[PATCH 6/6] dmaengine: ste_dma40: fix error return code

2014-11-22 Thread Julia Lawall
From: Julia Lawall Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret =