Re: [PATCH 6/6] PM / OPP: Add debugfs support

2015-08-10 Thread Viresh Kumar
On 10-08-15, 12:50, Stephen Boyd wrote: > The dev_name thing is going to fail. Eventually we'll get into a > situation where two devices with the same name on different > busses have OPPs. When we add them to debugfs their names are > going to conflict. The regulator core suffered this problem, see

Re: [PATCH 6/6] PM / OPP: Add debugfs support

2015-08-10 Thread Viresh Kumar
On 10-08-15, 12:50, Stephen Boyd wrote: > > + /* Create device specific directory link */ > > + d = debugfs_create_symlink(dev_name(dev), rootdir, > > The dev_name thing is going to fail. Eventually we'll get into a > situation where two devices with the same name on different > busses have OP

Re: [PATCH 6/6] PM / OPP: Add debugfs support

2015-08-10 Thread Stephen Boyd
On 08/10, Viresh Kumar wrote: > diff --git a/drivers/base/power/opp/debugfs.c > b/drivers/base/power/opp/debugfs.c > new file mode 100644 > index ..d4e18eac8278 > --- /dev/null > +++ b/drivers/base/power/opp/debugfs.c > @@ -0,0 +1,165 @@ > +/* > + * Generic OPP debugfs interface > + *

[PATCH 6/6] PM / OPP: Add debugfs support

2015-08-09 Thread Viresh Kumar
This patch adds debugfs support to OPP layer to export OPPs and their properties for all the devices. This creates a top level directory: /sys/kernel/debug/opp and then device specific directories (based on device names) inside it. For example: 'cpu0', 'cpu1', etc.. If multiple devices share the