Re: [PATCH 6/6] Fix unsafe fw_event_list usage

2015-07-11 Thread Calvin Owens
On Friday 07/03 at 09:02 -0700, Christoph Hellwig wrote: > On Mon, Jun 08, 2015 at 08:50:56PM -0700, Calvin Owens wrote: > > Since the fw_event deletes itself from the list, cleanup_queue() can > > walk onto garbage pointers or walk off into freed memory. > > > > This refactors the code in _scsih_

Re: [PATCH 6/6] Fix unsafe fw_event_list usage

2015-07-03 Thread Christoph Hellwig
On Mon, Jun 08, 2015 at 08:50:56PM -0700, Calvin Owens wrote: > Since the fw_event deletes itself from the list, cleanup_queue() can > walk onto garbage pointers or walk off into freed memory. > > This refactors the code in _scsih_fw_event_cleanup_queue() to not > iterate over the fw_event_list wi

[PATCH 6/6] Fix unsafe fw_event_list usage

2015-06-08 Thread Calvin Owens
Since the fw_event deletes itself from the list, cleanup_queue() can walk onto garbage pointers or walk off into freed memory. This refactors the code in _scsih_fw_event_cleanup_queue() to not iterate over the fw_event_list without a lock. Signed-off-by: Calvin Owens --- drivers/scsi/mpt2sas/m

[PATCH 6/6] Fix unsafe fw_event_list usage

2015-05-14 Thread Calvin Owens
Since the fw_event deletes itself from the list, cleanup_queue() can walk onto garbage pointers or walk off into freed memory. This refactors the code in _scsih_fw_event_cleanup_queue() to not iterate over the fw_event_list without a lock. Signed-off-by: Calvin Owens --- drivers/scsi/mpt2sas/m