Re: [PATCH 6/13] maps: Move the page walker code to lib/

2007-04-04 Thread Nick Piggin
Nick Piggin wrote: Matt Mackall wrote: On Wed, Apr 04, 2007 at 03:50:56PM +1000, Nick Piggin wrote: Just put it in its own file in mm/ rather than its own file in lib. lib should be for almost-standalone stuff, IMO (ie. only using basic kernel functionality). Arguably that's what lib/ sh

Re: [PATCH 6/13] maps: Move the page walker code to lib/

2007-04-04 Thread Nick Piggin
Matt Mackall wrote: On Wed, Apr 04, 2007 at 03:50:56PM +1000, Nick Piggin wrote: Matt Mackall wrote: On Wed, Apr 04, 2007 at 01:51:37PM +1000, Nick Piggin wrote: Matt Mackall wrote: Move the page walker code to lib/ This lets it get shared outside of proc/ and linked in only when neede

Re: [PATCH 6/13] maps: Move the page walker code to lib/

2007-04-04 Thread Matt Mackall
On Wed, Apr 04, 2007 at 03:50:56PM +1000, Nick Piggin wrote: > Matt Mackall wrote: > >On Wed, Apr 04, 2007 at 01:51:37PM +1000, Nick Piggin wrote: > > > >>Matt Mackall wrote: > >> > >>>Move the page walker code to lib/ > >>> > >>>This lets it get shared outside of proc/ and linked in only when > >>

Re: [PATCH 6/13] maps: Move the page walker code to lib/

2007-04-03 Thread Nick Piggin
Matt Mackall wrote: On Wed, Apr 04, 2007 at 01:51:37PM +1000, Nick Piggin wrote: Matt Mackall wrote: Move the page walker code to lib/ This lets it get shared outside of proc/ and linked in only when needed. I think it would be better in mm/. I originally was looking at putting it in mm

Re: [PATCH 6/13] maps: Move the page walker code to lib/

2007-04-03 Thread Matt Mackall
On Wed, Apr 04, 2007 at 01:51:37PM +1000, Nick Piggin wrote: > Matt Mackall wrote: > >Move the page walker code to lib/ > > > >This lets it get shared outside of proc/ and linked in only when > >needed. > > I think it would be better in mm/. I originally was looking at putting it in mm/memory.c a

Re: [PATCH 6/13] maps: Move the page walker code to lib/

2007-04-03 Thread Nick Piggin
Matt Mackall wrote: Move the page walker code to lib/ This lets it get shared outside of proc/ and linked in only when needed. I think it would be better in mm/. So would clear_refs_pte_range, and clear_refs_write (in a more generic form), IMO. Sweet patchset, though. -- SUSE Labs, Novell I

[PATCH 6/13] maps: Move the page walker code to lib/

2007-04-03 Thread Matt Mackall
Move the page walker code to lib/ This lets it get shared outside of proc/ and linked in only when needed. Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-27 2