Re: [PATCH 58/59] sysctl: Reimplement the sysctl proc support

2007-03-14 Thread Michal Schmidt
Ingo Molnar wrote: > * Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > >> Use register_sysctl_table() for sysctls. >> > > yes - i just wanted to point out the incompatibility and subtle breakage > that this change caused. I'll now have to convert the current code over > to sysctl_table, whic

Re: [PATCH 58/59] sysctl: Reimplement the sysctl proc support

2007-03-14 Thread Ingo Molnar
* Eric W. Biederman <[EMAIL PROTECTED]> wrote: > However it has always been a bug for anything under /proc/sys to not > be a sysctl. It's not subtle breakage but subtle enforcement of the > existing rules. it wasnt really a bug but an uncleanliness - but yeah. The way i used it is pretty much

Re: [PATCH 58/59] sysctl: Reimplement the sysctl proc support

2007-03-14 Thread Eric W. Biederman
Ingo Molnar <[EMAIL PROTECTED]> writes: > * Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > >> On 3/14/07, Ingo Molnar <[EMAIL PROTECTED]> wrote: >> > #define PROCNAME_PML"sys/kernel/preempt_max_latency" >> > >> > static __init int latency_fs_init(void) >> > { >> > struct proc_dir_entry *

Re: [PATCH 58/59] sysctl: Reimplement the sysctl proc support

2007-03-14 Thread Ingo Molnar
* Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > On 3/14/07, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > #define PROCNAME_PML"sys/kernel/preempt_max_latency" > > > > static __init int latency_fs_init(void) > > { > > struct proc_dir_entry *entry; > > > > if (!(entry = create_proc_

Re: [PATCH 58/59] sysctl: Reimplement the sysctl proc support

2007-03-14 Thread Alexey Dobriyan
On 3/14/07, Ingo Molnar <[EMAIL PROTECTED]> wrote: #define PROCNAME_PML"sys/kernel/preempt_max_latency" static __init int latency_fs_init(void) { struct proc_dir_entry *entry; if (!(entry = create_proc_entry(PROCNAME_PML, 0644, NULL))) printk("latency_f

Re: [PATCH 58/59] sysctl: Reimplement the sysctl proc support

2007-03-14 Thread Ingo Molnar
* Eric W. Biederman <[EMAIL PROTECTED]> wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > With this change the sysctl inodes can be cached and nothing needs to > be done when removing a sysctl table. your change is now upstream: commit 77b14db502cb85a031fe8fde6c85d52f3e0ac

[PATCH 58/59] sysctl: Reimplement the sysctl proc support

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted With this change the sysctl inodes can be cached and nothing needs to be done when removing a sysctl table. For a costk of 2K code we will save about 4K of static tables (when we remove de from ctl_table) and 70K in proc_dir_entries that we w