Re: [PATCH 5/8] zram: add dynamic device add/remove functionality

2015-03-04 Thread Sergey Senozhatsky
On (03/04/15 17:19), Sergey Senozhatsky wrote: > hm... that actually doesn't look so hard. > > all I need to do is just change zram_add attr to RW (or create a new RO > attribute `zram_auto_add', or whatever) and treat read access to that > zram_add_read() or zram_auto_add_read() attr as (atomic o

Re: [PATCH 5/8] zram: add dynamic device add/remove functionality

2015-03-04 Thread Sergey Senozhatsky
On (03/04/15 16:29), Sergey Senozhatsky wrote: > > Why should user specifiy zram-device id to create? > > > > one of them will create a new device, the other one will get -EEXIST. > quite decent. > > I'm not sure I know how to return device id back to use space in > response to > echo -1 >

Re: [PATCH 5/8] zram: add dynamic device add/remove functionality

2015-03-03 Thread Sergey Senozhatsky
On (03/04/15 16:10), Minchan Kim wrote: > On Tue, Mar 03, 2015 at 09:49:47PM +0900, Sergey Senozhatsky wrote: > > Introduce zram-control sysfs class, which has two sysfs attrs: > > - zram_add -- add a new specific (device_id) zram device > > - zram_remove -- remove a specific (device_id) zra

Re: [PATCH 5/8] zram: add dynamic device add/remove functionality

2015-03-03 Thread Minchan Kim
On Tue, Mar 03, 2015 at 09:49:47PM +0900, Sergey Senozhatsky wrote: > Introduce zram-control sysfs class, which has two sysfs attrs: > - zram_add -- add a new specific (device_id) zram device > - zram_remove -- remove a specific (device_id) zram device > > Usage example: > # add a new

Re: [PATCH 5/8] zram: add dynamic device add/remove functionality

2015-03-03 Thread Sergey Senozhatsky
On (03/03/15 14:01), Andrew Morton wrote: > > Introduce zram-control sysfs class, which has two sysfs attrs: > > - zram_add -- add a new specific (device_id) zram device > > - zram_remove -- remove a specific (device_id) zram device > > > > Usage example: > > # add a new specific zram d

Re: [PATCH 5/8] zram: add dynamic device add/remove functionality

2015-03-03 Thread Andrew Morton
On Tue, 3 Mar 2015 21:49:47 +0900 Sergey Senozhatsky wrote: > Introduce zram-control sysfs class, which has two sysfs attrs: > - zram_add -- add a new specific (device_id) zram device > - zram_remove -- remove a specific (device_id) zram device > > Usage example: > # add a new spe

[PATCH 5/8] zram: add dynamic device add/remove functionality

2015-03-03 Thread Sergey Senozhatsky
Introduce zram-control sysfs class, which has two sysfs attrs: - zram_add -- add a new specific (device_id) zram device - zram_remove -- remove a specific (device_id) zram device Usage example: # add a new specific zram device echo 4 > /sys/class/zram-control/zram_add