Re: [PATCH 5/8] minnowboard-gpio: Export MinnowBoard expansion GPIO

2013-06-27 Thread Darren Hart
On Thu, 2013-06-27 at 11:18 +0300, Andy Shevchenko wrote: > On Wed, 2013-06-26 at 09:21 -0700, Darren Hart wrote: > > On Wed, 2013-06-26 at 10:55 +0300, Andy Shevchenko wrote: > > > > > + out: > > > > + return err; > > > > > > Are you planning to add something else to 'out' path? > > > Oth

Re: [PATCH 5/8] minnowboard-gpio: Export MinnowBoard expansion GPIO

2013-06-27 Thread Andy Shevchenko
On Wed, 2013-06-26 at 09:21 -0700, Darren Hart wrote: > On Wed, 2013-06-26 at 10:55 +0300, Andy Shevchenko wrote: > > > + out: > > > + return err; > > > > Are you planning to add something else to 'out' path? > > Otherwise I think it will look better if you do return instead of > > [useless] got

Re: [PATCH 5/8] minnowboard-gpio: Export MinnowBoard expansion GPIO

2013-06-26 Thread Darren Hart
On Wed, 2013-06-26 at 10:55 +0300, Andy Shevchenko wrote: > On Tue, 2013-06-25 at 18:53 -0700, Darren Hart wrote: > > Request and export the user-configurable GPIO lines to sysfs. This provides > > a > > label readable in /debugfs/gpio and a simple interface for experimenting > > with > > GPIO o

Re: [PATCH 5/8] minnowboard-gpio: Export MinnowBoard expansion GPIO

2013-06-26 Thread Andy Shevchenko
On Tue, 2013-06-25 at 18:53 -0700, Darren Hart wrote: > Request and export the user-configurable GPIO lines to sysfs. This provides a > label readable in /debugfs/gpio and a simple interface for experimenting with > GPIO on the MinnowBoard. > > This is separate from the minnowboard driver to prov

[PATCH 5/8] minnowboard-gpio: Export MinnowBoard expansion GPIO

2013-06-25 Thread Darren Hart
Request and export the user-configurable GPIO lines to sysfs. This provides a label readable in /debugfs/gpio and a simple interface for experimenting with GPIO on the MinnowBoard. This is separate from the minnowboard driver to provide users with the flexibility to write kernel drivers for their