Re: [PATCH 5/8] device: avoid format string in dev_set_name

2013-06-07 Thread Greg Kroah-Hartman
On Thu, Jun 06, 2013 at 01:52:22PM -0700, Kees Cook wrote: > --- a/mm/backing-dev.c > +++ b/mm/backing-dev.c > @@ -515,7 +515,6 @@ EXPORT_SYMBOL(bdi_destroy); > int bdi_setup_and_register(struct backing_dev_info *bdi, char *name, > unsigned int cap) > { > - char tmp[3

[PATCH 5/8] device: avoid format string in dev_set_name

2013-06-06 Thread Kees Cook
Calling dev_set_name with a single paramter causes it to be handled as a format string. Many callers are passing potentially dynamic string content, so use "%s" in those cases to avoid any potential accidents, including wrappers like device_create*() and bdi_register(). Signed-off-by: Kees Cook -