Re: [PATCH 5/7] perf metricgroup: Remove duped metric group events

2020-05-21 Thread Arnaldo Carvalho de Melo
Em Thu, May 21, 2020 at 10:26:02AM -0700, Ian Rogers escreveu: > On Thu, May 21, 2020 at 3:54 AM Jiri Olsa wrote: > > ok, I misunderstood and thought you would colaps also M3 to > > have A,B computed via M1 group and with separate D ... > > > > thanks a lot for the explanation, it might be great t

Re: [PATCH 5/7] perf metricgroup: Remove duped metric group events

2020-05-21 Thread Ian Rogers
On Thu, May 21, 2020 at 3:54 AM Jiri Olsa wrote: > > On Wed, May 20, 2020 at 03:42:02PM -0700, Ian Rogers wrote: > > SNIP > > > > > > > hum, I think that's also concern if you are multiplexing 2 groups and one > > > metric getting events from both groups that were not meassured together > > > > >

Re: [PATCH 5/7] perf metricgroup: Remove duped metric group events

2020-05-21 Thread Jiri Olsa
On Wed, May 20, 2020 at 03:42:02PM -0700, Ian Rogers wrote: SNIP > > > > hum, I think that's also concern if you are multiplexing 2 groups and one > > metric getting events from both groups that were not meassured together > > > > it makes sense to me put all the merged events into single weak gr

Re: [PATCH 5/7] perf metricgroup: Remove duped metric group events

2020-05-20 Thread Ian Rogers
On Wed, May 20, 2020 at 3:09 PM Jiri Olsa wrote: > > On Wed, May 20, 2020 at 09:50:13AM -0700, Ian Rogers wrote: > > SNIP > > > > > + } > > > > > > is the groupping still enabled when we merge groups? could part > > > of the metric (events) be now computed in different groups? > > > >

Re: [PATCH 5/7] perf metricgroup: Remove duped metric group events

2020-05-20 Thread Jiri Olsa
On Wed, May 20, 2020 at 09:50:13AM -0700, Ian Rogers wrote: SNIP > > > + } > > > > is the groupping still enabled when we merge groups? could part > > of the metric (events) be now computed in different groups? > > By default the change will take two metrics and allow the shorter > m

Re: [PATCH 5/7] perf metricgroup: Remove duped metric group events

2020-05-20 Thread Ian Rogers
On Wed, May 20, 2020 at 6:49 AM Jiri Olsa wrote: > > On Wed, May 20, 2020 at 12:28:12AM -0700, Ian Rogers wrote: > > SNIP > > > > > @@ -157,7 +183,7 @@ static int metricgroup__setup_events(struct list_head > > *groups, > > int i = 0; > > int ret = 0; > > struct egroup *eg; > > -

Re: [PATCH 5/7] perf metricgroup: Remove duped metric group events

2020-05-20 Thread Jiri Olsa
On Wed, May 20, 2020 at 12:28:12AM -0700, Ian Rogers wrote: SNIP > > @@ -157,7 +183,7 @@ static int metricgroup__setup_events(struct list_head > *groups, > int i = 0; > int ret = 0; > struct egroup *eg; > - struct evsel *evsel; > + struct evsel *evsel, *tmp; > u

[PATCH 5/7] perf metricgroup: Remove duped metric group events

2020-05-20 Thread Ian Rogers
A metric group contains multiple metrics. These metrics may use the same events. If metrics use separate events then it leads to more multiplexing and overall metric counts fail to sum to 100%. Modify how metrics are associated with events so that if the events in an earlier group satisfy the curre