Re: [PATCH 5/7] mmc: meson-gx: avoid clock glitch when switching to DDR modes

2019-04-20 Thread Martin Blumenstingl
Hi Jerome, On Fri, Apr 19, 2019 at 10:53 AM Jerome Brunet wrote: > > On Thu, 2019-04-18 at 23:15 +0200, Jerome Brunet wrote: > > On Thu, 2019-04-18 at 22:53 +0200, Martin Blumenstingl wrote: > > > Hi Jerome, > > > > > > On Thu, Apr 18, 2019 at 10:46 PM Jerome Brunet > > > wrote: > > > > On Thu,

Re: [PATCH 5/7] mmc: meson-gx: avoid clock glitch when switching to DDR modes

2019-04-19 Thread Jerome Brunet
On Thu, 2019-04-18 at 23:15 +0200, Jerome Brunet wrote: > On Thu, 2019-04-18 at 22:53 +0200, Martin Blumenstingl wrote: > > Hi Jerome, > > > > On Thu, Apr 18, 2019 at 10:46 PM Jerome Brunet wrote: > > > On Thu, 2019-04-18 at 22:16 +0200, Martin Blumenstingl wrote: > > > > Hi Jerome, > > > > > >

Re: [PATCH 5/7] mmc: meson-gx: avoid clock glitch when switching to DDR modes

2019-04-18 Thread Jerome Brunet
On Thu, 2019-04-18 at 22:53 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Thu, Apr 18, 2019 at 10:46 PM Jerome Brunet wrote: > > On Thu, 2019-04-18 at 22:16 +0200, Martin Blumenstingl wrote: > > > Hi Jerome, > > > > > > On Wed, Apr 17, 2019 at 10:44 PM Jerome Brunet > > > wrote: > > >

Re: [PATCH 5/7] mmc: meson-gx: avoid clock glitch when switching to DDR modes

2019-04-18 Thread Martin Blumenstingl
Hi Jerome, On Thu, Apr 18, 2019 at 10:46 PM Jerome Brunet wrote: > > On Thu, 2019-04-18 at 22:16 +0200, Martin Blumenstingl wrote: > > Hi Jerome, > > > > On Wed, Apr 17, 2019 at 10:44 PM Jerome Brunet wrote: > > > Activating DDR in the Amlogic mmc controller, among other things, will > > > divid

Re: [PATCH 5/7] mmc: meson-gx: avoid clock glitch when switching to DDR modes

2019-04-18 Thread Jerome Brunet
On Thu, 2019-04-18 at 22:16 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Wed, Apr 17, 2019 at 10:44 PM Jerome Brunet wrote: > > Activating DDR in the Amlogic mmc controller, among other things, will > > divide the output clock by 2. So by activating it with clock on, we are > > creating

Re: [PATCH 5/7] mmc: meson-gx: avoid clock glitch when switching to DDR modes

2019-04-18 Thread Martin Blumenstingl
Hi Jerome, On Wed, Apr 17, 2019 at 10:44 PM Jerome Brunet wrote: > > Activating DDR in the Amlogic mmc controller, among other things, will > divide the output clock by 2. So by activating it with clock on, we are > creating a glitch on the output. > > Instead, let's deal with DDR when the clock

[PATCH 5/7] mmc: meson-gx: avoid clock glitch when switching to DDR modes

2019-04-17 Thread Jerome Brunet
Activating DDR in the Amlogic mmc controller, among other things, will divide the output clock by 2. So by activating it with clock on, we are creating a glitch on the output. Instead, let's deal with DDR when the clock output is off, when setting the clock. Signed-off-by: Jerome Brunet --- dri