Re: [PATCH 5/7] gpio: brcmstb: enable masking of interrupts when changing type

2017-10-03 Thread Gregory Fong
On Tue, Oct 3, 2017 at 7:22 PM, Doug Berger wrote: > On 10/03/2017 07:10 PM, Gregory Fong wrote: >> Hi Doug, >> >> On Fri, Sep 29, 2017 at 8:40 PM, Doug Berger wrote: >>> Mask the GPIO interrupt while its type is being changed, just in case >>> it can prevent a spurious interrupt. >> >> "Just in

Re: [PATCH 5/7] gpio: brcmstb: enable masking of interrupts when changing type

2017-10-03 Thread Doug Berger
On 10/03/2017 07:10 PM, Gregory Fong wrote: > Hi Doug, > > On Fri, Sep 29, 2017 at 8:40 PM, Doug Berger wrote: >> Mask the GPIO interrupt while its type is being changed, just in case >> it can prevent a spurious interrupt. > > "Just in case"? I don't have access to hardware documentation for >

Re: [PATCH 5/7] gpio: brcmstb: enable masking of interrupts when changing type

2017-10-03 Thread Gregory Fong
Hi Doug, On Fri, Sep 29, 2017 at 8:40 PM, Doug Berger wrote: > Mask the GPIO interrupt while its type is being changed, just in case > it can prevent a spurious interrupt. "Just in case"? I don't have access to hardware documentation for this anymore, but I'd expect to some stronger claim that

[PATCH 5/7] gpio: brcmstb: enable masking of interrupts when changing type

2017-09-29 Thread Doug Berger
Mask the GPIO interrupt while its type is being changed, just in case it can prevent a spurious interrupt. Signed-off-by: Doug Berger --- drivers/gpio/gpio-brcmstb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c i