Re: [PATCH 5/6] xen: arm: implement remap interfaces needed for privcmd mappings.

2012-10-18 Thread Ian Campbell
On Thu, 2012-10-18 at 14:35 +0100, Stefano Stabellini wrote: > On Thu, 18 Oct 2012, Ian Campbell wrote: > > On Thu, 2012-10-18 at 14:27 +0100, Stefano Stabellini wrote: > > > On Wed, 17 Oct 2012, Ian Campbell wrote: > > > > We use XENMEM_add_to_physmap_range which is the preferred interface > > > >

Re: [PATCH 5/6] xen: arm: implement remap interfaces needed for privcmd mappings.

2012-10-18 Thread Stefano Stabellini
On Thu, 18 Oct 2012, Ian Campbell wrote: > On Thu, 2012-10-18 at 14:27 +0100, Stefano Stabellini wrote: > > On Wed, 17 Oct 2012, Ian Campbell wrote: > > > We use XENMEM_add_to_physmap_range which is the preferred interface > > > for foreign mappings. > > > > > > Signed-off-by: Ian Campbell > > >

Re: [PATCH 5/6] xen: arm: implement remap interfaces needed for privcmd mappings.

2012-10-18 Thread Ian Campbell
On Thu, 2012-10-18 at 14:27 +0100, Stefano Stabellini wrote: > On Wed, 17 Oct 2012, Ian Campbell wrote: > > We use XENMEM_add_to_physmap_range which is the preferred interface > > for foreign mappings. > > > > Signed-off-by: Ian Campbell > > It looks OK but there are few code style issues, pleas

Re: [PATCH 5/6] xen: arm: implement remap interfaces needed for privcmd mappings.

2012-10-18 Thread Stefano Stabellini
On Wed, 17 Oct 2012, Ian Campbell wrote: > We use XENMEM_add_to_physmap_range which is the preferred interface > for foreign mappings. > > Signed-off-by: Ian Campbell It looks OK but there are few code style issues, please run the patch through checkpatch. > arch/arm/include/asm/xen/interface

[PATCH 5/6] xen: arm: implement remap interfaces needed for privcmd mappings.

2012-10-17 Thread Ian Campbell
We use XENMEM_add_to_physmap_range which is the preferred interface for foreign mappings. Signed-off-by: Ian Campbell --- arch/arm/include/asm/xen/interface.h |1 + arch/arm/xen/enlighten.c | 100 +- arch/x86/include/asm/xen/interface.h |1 +