Re: [PATCH 5/6] rcuscale: Do a proper cleanup if kfree_scale_init() fails

2024-11-11 Thread Uladzislau Rezki
On Mon, Nov 11, 2024 at 11:53:45AM +0100, Uladzislau Rezki wrote: > On Mon, Nov 11, 2024 at 03:24:38PM +0530, Neeraj Upadhyay wrote: > > > > > diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c > > > index 6d37596deb1f..de7d511e6be4 100644 > > > --- a/kernel/rcu/rcuscale.c > > > +++ b/kern

Re: [PATCH 5/6] rcuscale: Do a proper cleanup if kfree_scale_init() fails

2024-11-11 Thread Uladzislau Rezki
On Mon, Nov 11, 2024 at 03:24:38PM +0530, Neeraj Upadhyay wrote: > > > diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c > > index 6d37596deb1f..de7d511e6be4 100644 > > --- a/kernel/rcu/rcuscale.c > > +++ b/kernel/rcu/rcuscale.c > > @@ -890,13 +890,13 @@ kfree_scale_init(void) > >

Re: [PATCH 5/6] rcuscale: Do a proper cleanup if kfree_scale_init() fails

2024-11-11 Thread Neeraj Upadhyay
> diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c > index 6d37596deb1f..de7d511e6be4 100644 > --- a/kernel/rcu/rcuscale.c > +++ b/kernel/rcu/rcuscale.c > @@ -890,13 +890,13 @@ kfree_scale_init(void) > if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start < 2 * HZ)) { >

[PATCH 5/6] rcuscale: Do a proper cleanup if kfree_scale_init() fails

2024-11-06 Thread Frederic Weisbecker
From: "Uladzislau Rezki (Sony)" A static analyzer for C, Smatch, reports and triggers below warnings: kernel/rcu/rcuscale.c:1215 rcu_scale_init() warn: inconsistent returns 'global &fullstop_mutex'. The checker complains about, we do not unlock the "fullstop_mutex" mutex, in case of hitti