Re: [PATCH 5/6] powerpc: Implement DISCONTIGMEM and allow selection on PPC32

2018-02-21 Thread christophe leroy
Le 21/02/2018 à 17:08, Jonathan Neuschäfer a écrit : On Wed, Feb 21, 2018 at 07:46:28AM +0800, kbuild test robot wrote: [...] include/linux/mmzone.h:1239:19: error: conflicting types for 'pfn_valid' static inline int pfn_valid(unsigned long pfn) ^ In fi

Re: [PATCH 5/6] powerpc: Implement DISCONTIGMEM and allow selection on PPC32

2018-02-21 Thread Jonathan Neuschäfer
On Wed, Feb 21, 2018 at 07:46:28AM +0800, kbuild test robot wrote: [...] > >> include/linux/mmzone.h:1239:19: error: conflicting types for 'pfn_valid' > static inline int pfn_valid(unsigned long pfn) > ^ >In file included from include/linux/mmzone.h:912:0, >

Re: [PATCH 5/6] powerpc: Implement DISCONTIGMEM and allow selection on PPC32

2018-02-20 Thread kbuild test robot
Hi Jonathan, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v4.16-rc2 next-20180220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[PATCH 5/6] powerpc: Implement DISCONTIGMEM and allow selection on PPC32

2018-02-20 Thread Jonathan Neuschäfer
The implementation of pfn_to_nid and pfn_valid in mmzone.h is based on arch/metag's implementation. Signed-off-by: Jonathan Neuschäfer --- NOTE: Checking NODE_DATA(nid) in pfn_to_nid appears to be uncommon. Running up to MAX_NUMNODES instead of checking NODE_DATA(nid) would require the node_data