Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32

2017-07-04 Thread Wolfram Sang
> >> Frankly, I am not a big fan of converting board files if we cannot test > >> the changes. > > > > So, if no one is using that old boards, should we really take care > > more than just compile test? > > > > P.S. Legacy platform data makes a burden of development nowadays. > > Built-in device

Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32

2017-07-02 Thread Chris Packham
On 30/06/17 22:56, Andy Shevchenko wrote: > On Fri, Jun 30, 2017 at 12:03 PM, Wolfram Sang wrote: >> - i2c->algo_data.i2c_clock = 59000; + ret = device_property_read_u32(&pdev->dev, "clock-frequency", + &

Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32

2017-06-30 Thread Andy Shevchenko
On Fri, Jun 30, 2017 at 12:03 PM, Wolfram Sang wrote: > >> > - i2c->algo_data.i2c_clock = 59000; >> > + ret = device_property_read_u32(&pdev->dev, >> > "clock-frequency", >> > + &i2c->algo_data.i2c_clock); >> > +

Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32

2017-06-30 Thread Wolfram Sang
> > - i2c->algo_data.i2c_clock = 59000; > > + ret = device_property_read_u32(&pdev->dev, > > "clock-frequency", > > + &i2c->algo_data.i2c_clock); > > + if (ret) > > + i2c->algo_data.i2c_cl

Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32

2017-06-30 Thread Andy Shevchenko
On Fri, Jun 30, 2017 at 3:54 AM, Chris Packham wrote: > Use device_property_read_u32 instead of of_property_read_u32_index to > lookup the "clock-frequency" property. My comments below. > > Signed-off-by: Chris Packham > --- > drivers/i2c/busses/i2c-pca-platform.c | 9 - > 1 file chang

[PATCH 5/6] i2c: pca-platform: use device_property_read_u32

2017-06-29 Thread Chris Packham
Use device_property_read_u32 instead of of_property_read_u32_index to lookup the "clock-frequency" property. Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-pca-platform.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-pca-platform.c