Re: [PATCH 5/6] gpio / ACPI: Rework ACPI GPIO event handling

2014-02-26 Thread Mika Westerberg
On Tue, Feb 25, 2014 at 03:44:52PM +0100, Rafael J. Wysocki wrote: > On Monday, February 24, 2014 06:00:10 PM Mika Westerberg wrote: > > The current ACPI GPIO event handling code was never tested against real > > hardware with functioning GPIO triggered events (at the time such hardware > > wasn't

Re: [PATCH 5/6] gpio / ACPI: Rework ACPI GPIO event handling

2014-02-25 Thread Rafael J. Wysocki
On Monday, February 24, 2014 06:00:10 PM Mika Westerberg wrote: > The current ACPI GPIO event handling code was never tested against real > hardware with functioning GPIO triggered events (at the time such hardware > wasn't available). Thus it misses certain things like requesting the GPIOs > prope

[PATCH 5/6] gpio / ACPI: Rework ACPI GPIO event handling

2014-02-24 Thread Mika Westerberg
The current ACPI GPIO event handling code was never tested against real hardware with functioning GPIO triggered events (at the time such hardware wasn't available). Thus it misses certain things like requesting the GPIOs properly, passing correct flags to the interrupt handler and so on. This pat