Re: [PATCH 5/6] e1000 driver remove checkpatch errors, warnings and checks.

2015-10-13 Thread Jeff Kirsher
On Tue, 2015-10-13 at 15:23 -0700, Alexander Duyck wrote: > On 10/13/2015 02:39 PM, Janusz Wolak wrote: > > From: Janusz Wolak > > > > Signed-off-by: Janusz Wolak > > --- > > drivers/net/ethernet/intel/e1000/e1000_param.c | 114 > ++--- > > 1 file changed, 82 insertions(+),

Re: [PATCH 5/6] e1000 driver remove checkpatch errors, warnings and checks.

2015-10-13 Thread Joe Perches
On Tue, 2015-10-13 at 15:23 -0700, Alexander Duyck wrote: > Please don't just blindly > follow checkpatch as it can give out erroneous information. > > Looking over most of this patch series it seems like it is taking > readability in the wrong direction and reducing the ability to maintain > t

Re: [PATCH 5/6] e1000 driver remove checkpatch errors, warnings and checks.

2015-10-13 Thread Alexander Duyck
On 10/13/2015 02:39 PM, Janusz Wolak wrote: From: Janusz Wolak Signed-off-by: Janusz Wolak --- drivers/net/ethernet/intel/e1000/e1000_param.c | 114 ++--- 1 file changed, 82 insertions(+), 32 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_param.c b/dr

[PATCH 5/6] e1000 driver remove checkpatch errors, warnings and checks.

2015-10-13 Thread Janusz Wolak
From: Janusz Wolak Signed-off-by: Janusz Wolak --- drivers/net/ethernet/intel/e1000/e1000_param.c | 114 ++--- 1 file changed, 82 insertions(+), 32 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_param.c b/drivers/net/ethernet/intel/e1000/e1000_param.c ind