Re: [PATCH 5/5] virtio: don't require a config space on the console device.

2015-02-11 Thread Amit Shah
On (Mon) 09 Feb 2015 [10:26:29], Rusty Russell wrote: > virtio: don't require a config space on the console device. > > Strictly, it's only needed when we have features (size or multiport). > > Signed-off-by: Rusty Russell Reviewed-by: Amit Shah > diff --git a/drivers/char/virtio_console.c b/

Re: [PATCH 5/5] virtio: don't require a config space on the console device.

2015-02-08 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Fri, Feb 06, 2015 at 03:36:56PM +1030, Rusty Russell wrote: >> Strictly, it's only needed when we have features (size or multiport). >> >> Signed-off-by: Rusty Russell >> --- >> drivers/char/virtio_console.c | 12 >> 1 file changed, 8 insertions(+)

Re: [PATCH 5/5] virtio: don't require a config space on the console device.

2015-02-08 Thread Michael S. Tsirkin
On Fri, Feb 06, 2015 at 03:36:56PM +1030, Rusty Russell wrote: > Strictly, it's only needed when we have features (size or multiport). > > Signed-off-by: Rusty Russell > --- > drivers/char/virtio_console.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/dri

[PATCH 5/5] virtio: don't require a config space on the console device.

2015-02-05 Thread Rusty Russell
Strictly, it's only needed when we have features (size or multiport). Signed-off-by: Rusty Russell --- drivers/char/virtio_console.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 26afb56a8073..