Re: [PATCH 5/5] spi: fix return value check in hspi_probe().

2013-01-11 Thread Dan Carpenter
On Fri, Jan 11, 2013 at 03:02:02PM +, Grant Likely wrote: > On Thu, 3 Jan 2013 19:04:55 +0300, Dan Carpenter > wrote: > > On Sat, Dec 22, 2012 at 09:56:20AM +, Grant Likely wrote: > > > On Wed, 19 Dec 2012 19:39:14 +0300, Dan Carpenter > > > wrote: > > > > On Wed, Dec 19, 2012 at 03:11:

Re: [PATCH 5/5] spi: fix return value check in hspi_probe().

2013-01-11 Thread Grant Likely
On Thu, 3 Jan 2013 19:04:55 +0300, Dan Carpenter wrote: > On Sat, Dec 22, 2012 at 09:56:20AM +, Grant Likely wrote: > > On Wed, 19 Dec 2012 19:39:14 +0300, Dan Carpenter > > wrote: > > > On Wed, Dec 19, 2012 at 03:11:54PM +, Grant Likely wrote: > > > > On Tue, 11 Dec 2012 16:36:27 -0800

Re: [PATCH 5/5] spi: fix return value check in hspi_probe().

2013-01-03 Thread Dan Carpenter
On Sat, Dec 22, 2012 at 09:56:20AM +, Grant Likely wrote: > On Wed, 19 Dec 2012 19:39:14 +0300, Dan Carpenter > wrote: > > On Wed, Dec 19, 2012 at 03:11:54PM +, Grant Likely wrote: > > > On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto > > > wrote: > > > > > > > > Hi > > > >

Re: [PATCH 5/5] spi: fix return value check in hspi_probe().

2012-12-22 Thread Grant Likely
On Wed, 19 Dec 2012 19:39:14 +0300, Dan Carpenter wrote: > On Wed, Dec 19, 2012 at 03:11:54PM +, Grant Likely wrote: > > On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto > > wrote: > > > > > > Hi > > > > > > > According to its documentation, clk_get() returns a "valid IS_ERR()

Re: [PATCH 5/5] spi: fix return value check in hspi_probe().

2012-12-19 Thread Dan Carpenter
On Wed, Dec 19, 2012 at 03:11:54PM +, Grant Likely wrote: > On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto > wrote: > > > > Hi > > > > > According to its documentation, clk_get() returns a "valid IS_ERR() > > > condition > > > containing errno", so we should call IS_ERR() rath

Re: [PATCH 5/5] spi: fix return value check in hspi_probe().

2012-12-19 Thread Grant Likely
On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto wrote: > > Hi > > > According to its documentation, clk_get() returns a "valid IS_ERR() > > condition > > containing errno", so we should call IS_ERR() rather than a NULL check. > > > > Signed-off-by: Cyril Roelandt > > Acked-by: K

Re: [PATCH 5/5] spi: fix return value check in hspi_probe().

2012-12-11 Thread Kuninori Morimoto
Hi > According to its documentation, clk_get() returns a "valid IS_ERR() condition > containing errno", so we should call IS_ERR() rather than a NULL check. > > Signed-off-by: Cyril Roelandt Acked-by: Kuninori Morimoto > --- > drivers/spi/spi-sh-hspi.c |2 +- > 1 file changed, 1 inserti

[PATCH 5/5] spi: fix return value check in hspi_probe().

2012-12-11 Thread Cyril Roelandt
According to its documentation, clk_get() returns a "valid IS_ERR() condition containing errno", so we should call IS_ERR() rather than a NULL check. Signed-off-by: Cyril Roelandt --- drivers/spi/spi-sh-hspi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi