Re: [PATCH 5/5] ixgbe: add driver set_max_vfs support

2012-10-03 Thread Yinghai Lu
On Wed, Oct 3, 2012 at 11:47 AM, Alexander Duyck wrote: > The ixgbe_set_max_vfs function has several issues. The two big ones are > that this function assumes it can just enable/disable SR-IOV without any > other changes being necessary which is not the case. I would recommend > looking at ixgbe

RE: [PATCH 5/5] ixgbe: add driver set_max_vfs support

2012-10-03 Thread Rose, Gregory V
com.com; > bhutchi...@solarflare.com; Rose, Gregory V; da...@davemloft.net--no-chain- > reply-to; Kirsher, Jeffrey T; Brandeburg, Jesse; David S. Miller; > Fastabend, John R; e1000-de...@lists.sourceforge.net; > net...@vger.kernel.org > Subject: Re: [PATCH 5/5] ixgbe: add driver set_max_vfs

Re: [PATCH 5/5] ixgbe: add driver set_max_vfs support

2012-10-03 Thread Don Dutile
On 10/03/2012 02:47 PM, Alexander Duyck wrote: On 10/03/2012 10:51 AM, Yinghai Lu wrote: Need ixgbe guys to close the loop to use set_max_vfs instead kernel parameters. Signed-off-by: Yinghai Lu Cc: Jeff Kirsher Cc: Jesse Brandeburg Cc: Greg Rose Cc: "David S. Miller" Cc: John Fastabend Cc: e10

Re: [PATCH 5/5] ixgbe: add driver set_max_vfs support

2012-10-03 Thread Alexander Duyck
On 10/03/2012 10:51 AM, Yinghai Lu wrote: > Need ixgbe guys to close the loop to use set_max_vfs instead > kernel parameters. > > Signed-off-by: Yinghai Lu > Cc: Jeff Kirsher > Cc: Jesse Brandeburg > Cc: Greg Rose > Cc: "David S. Miller" > Cc: John Fastabend > Cc: e1000-de...@lists.sourceforg

Re: [PATCH 5/5] ixgbe: add driver set_max_vfs support

2012-10-03 Thread Dan Carpenter
On Wed, Oct 03, 2012 at 10:51:35AM -0700, Yinghai Lu wrote: > Need ixgbe guys to close the loop to use set_max_vfs instead > kernel parameters. > > Signed-off-by: Yinghai Lu > Cc: Jeff Kirsher > Cc: Jesse Brandeburg > Cc: Greg Rose > Cc: "David S. Miller" > Cc: John Fastabend > Cc: e1000-de.

Re: [PATCH 5/5] ixgbe: add driver set_max_vfs support

2012-10-03 Thread Yinghai Lu
On Wed, Oct 3, 2012 at 10:51 AM, Yinghai Lu wrote: > Need ixgbe guys to close the loop to use set_max_vfs instead > kernel parameters. Sorry, I should put RFC in the subject line for this one. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

[PATCH 5/5] ixgbe: add driver set_max_vfs support

2012-10-03 Thread Yinghai Lu
Need ixgbe guys to close the loop to use set_max_vfs instead kernel parameters. Signed-off-by: Yinghai Lu Cc: Jeff Kirsher Cc: Jesse Brandeburg Cc: Greg Rose Cc: "David S. Miller" Cc: John Fastabend Cc: e1000-de...@lists.sourceforge.net Cc: net...@vger.kernel.org --- drivers/net/ethernet/in