Re: [PATCH 5/5] imx_dsp_rproc: Use reset controller API to control the DSP

2025-02-19 Thread Daniel Baluta
> > + case IMX_RPROC_RESET_CONTROLLER: > > + priv->reset = devm_reset_control_get_optional_exclusive(dev, > > NULL); > > Is this optional on purpose? There is no mention of it in the commit > message. Where is this resets property documented in the dt-bindings? For this particular

Re: [PATCH 5/5] imx_dsp_rproc: Use reset controller API to control the DSP

2025-02-18 Thread Peng Fan
On Tue, Feb 18, 2025 at 10:57:12AM +0200, Daniel Baluta wrote: >Use the reset controller API to control the DSP on i.MX8MP. This way >we can have a better control of the resources and avoid using a syscon >to access the audiomix bits. > >Signed-off-by: Daniel Baluta LGTM: Reviewed-by: Peng Fan

Re: [PATCH 5/5] imx_dsp_rproc: Use reset controller API to control the DSP

2025-02-18 Thread Philipp Zabel
On Di, 2025-02-18 at 10:57 +0200, Daniel Baluta wrote: > Use the reset controller API to control the DSP on i.MX8MP. This way > we can have a better control of the resources and avoid using a syscon > to access the audiomix bits. > > Signed-off-by: Daniel Baluta > --- > drivers/remoteproc/imx_ds

[PATCH 5/5] imx_dsp_rproc: Use reset controller API to control the DSP

2025-02-18 Thread Daniel Baluta
Use the reset controller API to control the DSP on i.MX8MP. This way we can have a better control of the resources and avoid using a syscon to access the audiomix bits. Signed-off-by: Daniel Baluta --- drivers/remoteproc/imx_dsp_rproc.c | 25 + drivers/remoteproc/imx_rpro